Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core-AAM: Add macOS mapping for aria-errormessage #620

Closed
wants to merge 3 commits into from

Conversation

joanmarie
Copy link
Contributor

Expose the textual content of the referenced element as the value of
AXHelp.

Fixes github issue #457.

Expose the textual content of the referenced element as the value of
AXHelp.

Fixes github issue #457.
@joanmarie joanmarie self-assigned this Aug 2, 2017
@joanmarie joanmarie requested a review from cookiecrook August 2, 2017 16:59
@joanmarie
Copy link
Contributor Author

@cookiecrook: Please review. Thanks!

@cookiecrook
Copy link
Contributor

We usually don't recommend putting any critical information in AXHelp, since a lot of users will disable VoiceOver speaking help text until a command is issued. I think our options are:

  • Append it to the label,
  • Trigger an announcement at the time it is shown, or
  • Expose it as a new TBD API.

@stes-acc
Copy link

stes-acc commented Aug 7, 2017 via email

@joanmarie
Copy link
Contributor Author

We usually don't recommend putting any critical information in AXHelp, since a lot of users will disable VoiceOver speaking help text until a command is issued. I think our options are:

  • Append it to the label,
  • Trigger an announcement at the time it is shown, or
  • Expose it as a new TBD API.

Fair enough. Thanks for the review!

Unfortunately, the lack of mapping is one of the things blocking the Core AAM from being able to enter CR. We really, really, really need to know what your platform's mapping is. Patches not only "welcome", but strongly encouraged. 😄

@cookiecrook
Copy link
Contributor

@stes-acc wrote:

Is there a specific key or/and gesture to speak AXHelp on request for a given control?

VO+Cmd+H will speak it on demand. Optionally, but by default, it will be spoken after a user-adjustable-length pause.

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but I added the last commits, so maybe you should review.

@joanmarie
Copy link
Contributor Author

Works for me, but I added the last commits, so maybe you should review.

Thanks! What you did works for me. But I couldn't be bothered to figure out how to use github's UI to change authorship as part of a squash and merge, so I just did it the old-fashioned way. 😄. a314c09.

Thanks again!

@joanmarie joanmarie closed this Aug 10, 2017
@joanmarie joanmarie deleted the macos-errormessage branch August 10, 2017 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants