Refactor identification of global states and properties #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adampage
added
the
editorial
jnurthen
requested changes
Oct 18, 2022
| @@ -203,6 +194,28 @@ function ariaAttributeReferences() { | |||
| node.replaceChild(l, parentNode); | |||
| } | |||
| } | |||
| // Annotate global attribute references | |||
There was a problem hiding this comment.
This file is maintained in aria-common - but having it here is great for now as it lets us test the changes.
There was a problem hiding this comment.
Ah, I see, thanks. Once this PR is finalized, would it be appropriate for me to create a separate PR for this file in the aria-common repo?
spectranaut
requested review from
JaninaSajka and
Jaunita-George
and removed request for
JaninaSajka
|
Hi @cyns , you mentioned a related issue in our weekly meeting today, but my brain was in scribing mode and I fear I missed the details. 😅 I searched our open issue list for “taxonomy” and “parent” but didn’t find anything that seemed applicable. Could I trouble you to help me track that down? |
|
Closing this as outdated -- this needs to wait until aria.js is refactored (in aria-common). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1823.
In reviewing the list of global states and properties, I found considerable overlap with the attributes already classified in the “6.6 Taxonomy...” section. As @JAWS-test reported, I discovered only 6 attributes that were missing from Taxonomy:
aria-braillelabelaria-brailleroledescriptionaria-currentaria-descriptionaria-keyshortcutsaria-roledescriptionIn this commit, I’m proposing a refactor which:
Adds the 6 missing states and properties to the Taxonomy section:
I put
aria-braillelabelin the “Widget Attributes” category since its purpose is similar toaria-label, which had already been classified in that list.I also put
aria-keyshortcutsin the “Widget Attributes” category since it felt like it belongs there.For now, I’ve put the remaining four in a new “Other Attributes” category since they didn’t appear to fit cleanly in any of the existing ones.
Updates
aria.jsto identify all global attributes in the Taxonomy section with an annotation of “(Global)” or similar.Removes the “Global States & Properties” section, but incorporates its descriptive language into the Taxonomy section.
Relocate the “Translatable Attributes” section so that the Taxonomy section may be more clearly understood as a complete collection of all ARIA attributes.
Preview | Diff