-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aria-description #1137
Add aria-description #1137
Conversation
Closes issue #891
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So excited to see this being added!
Co-Authored-By: Diane Ko <[email protected]>
… aria_description_issue_891
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my inline comments, I think it would be good to add a statement indicating which takes precedence when both aria-describedby
and aria-description
are used. There's a similar statement in this spec for aria-labelledby
:
As required by the accessible name and description computation, user agents give precedence to aria-labelledby over aria-label when computing the accessible name property.
I'm not sure how we want to deal with adding mention of an ARIA 1.3 property in AccName 1.2. Maybe that's a non-issue. OR we could add a statement that doesn't mention AccName, but instead has a "user agents MUST" statement regarding what should happen when authors use both aria-describedby
and aria-description
.
Should aria-description be prohibited on generic role? |
if so, then likely so should |
Co-Authored-By: Carolyn MacLeod <[email protected]>
I'm leaning against it as an unnecessary restriction and I'm not sure what the benefit would be Consider that not everything that has an annotation will be necessarily highlighted, and thus won't have a mark role. There is the possibility that something will have an annotation on a passage of text that only becomes obvious to visual users after you click on it. IMO it could be on a span, etc. With aria-label/name etc. I think the benefit of prohibiting it on some roles was that it would be possible to accidentally hide the inner contents from the AT. But that's not an issue here. |
Other than "similar to aria-label", nothing really says "this is invisible". Perhaps that should be explicit. |
After merging this, need to open an issue to update https://w3c.github.io/accname/ to say that aria-describedby overrides aria-description. |
… aria_description_issue_891
Co-Authored-By: Carolyn MacLeod <[email protected]>
@aleventhal Sorry for the back-and-forth, but I think your original phrase before c7113b6 was better, i.e:
(In fact, I think I'll provide a PR for aria-label to say "available in the DOM" as well... Edit: PR #1149. :) What I had in mind for visible was adding something like the following (paraphrased from aria-label):
Here are 2 possible places where that sentence could fit in (there may be others):
|
Ok, makes sense. I used the second option, but I added a "However, " to help things flow. What do you think? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version LGTM. Thanks for all your work on this!
Co-Authored-By: Carolyn MacLeod <[email protected]>
Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks!
* Add aria-description Co-Authored-By: Diane Ko <[email protected]> Co-Authored-By: Carolyn MacLeod <[email protected]>
Closes issue #891
Preview | Diff