-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revising what ARIA attributes should be considered global #999
Comments
I think aria-invalid & aria-errormessage are missing some.
|
updated the list to add those in. from here on out i won't edit the original list, just figured it made sense since discussion hadn't picked up yet. |
Also for consideration per today's call, |
Possibly related discussion regarding |
note: pending further discussion on I am curious as to the mechanism that would invoke the popup on a |
Probably need to allow AllTheThings on |
i'd submit they're not necessary on the |
@scottaohara |
fair point i suppose. i just typically think of it as a wrapper to the focusable elements within being it's a subclass of a structure role
that said, with |
Removes the following 4 attributes from global attributes: * aria-disabled * aria-errormessage * aria-haspopup * aria-invalid Adds the above attributes back as supported attributes on certain roles (and their subclasses), as follows: aria-disabled application button composite gridcell group input link menuitem scrollbar separator tab aria-errormessage application checkbox combobox gridcell listbox radiogroup slider spinbutton textbox tree aria-haspopup application button combobox gridcell menuitem slider tab textbox treeitem aria-invalid application checkbox combobox gridcell listbox radiogroup slider spinbutton textbox tree
Add Editors Note stating that implementations for this feature are still pending. Removes the following 4 attributes from global attributes: * aria-disabled * aria-errormessage * aria-haspopup * aria-invalid Adds the above attributes back as supported attributes on certain roles (and their subclasses), as follows: aria-disabled application button composite gridcell group input link menuitem scrollbar separator tab aria-errormessage application checkbox combobox gridcell listbox radiogroup slider spinbutton textbox tree aria-haspopup application button combobox gridcell menuitem slider tab textbox treeitem aria-invalid application checkbox combobox gridcell listbox radiogroup slider spinbutton textbox tree
Removes the following 4 attributes from global attributes: * aria-disabled * aria-errormessage * aria-haspopup * aria-invalid Adds the above attributes back as supported attributes on certain roles (and their subclasses), as follows: aria-disabled application button composite gridcell group input link menuitem scrollbar separator tab aria-errormessage application checkbox combobox gridcell listbox radiogroup slider spinbutton textbox tree aria-haspopup application button combobox gridcell menuitem slider tab textbox treeitem aria-invalid application checkbox combobox gridcell listbox radiogroup slider spinbutton textbox tree
Per mention in the WG call today, and spurred by the discussions started with #990, I've created the following break down for review of the attributes I believe should remain global, and those that should become either prohibited on roles where they don't make sense, or should be removed from being global attributes all together.
The following has been worded under the assumption the attributes would be removed from being global:
Attributes to remain global
aria-atomic
aria-busy
(state)aria-current
(state)aria-dropeffect
- "deprecated"aria-flowto
aria-grabbed
(state) - "deprecated"aria-hidden
(state)aria-live
aria-owns
aria-relevant
aria-roledescription
Attributes to remain global, but prohibited
Per other work already happening for
role=generic
and accName,aria-label
andaria-labelledby
have consensus of staying global, but should be noted as prohibited due to wanting to advice against naming certain roles.aria-label
aria-labelledby
I'd also submit that if a role shouldn't be named, it also likely shouldn't have a description associated with it...
aria-describedby
aria-details
Undecided
aria-keyshortcuts
I'm not exactly sure what to do with this one. Is there actual value in allowing keyboard shortcuts for non-interactive elements? I can't think of a reason, but maybe someone else?
Attributes to reallocate to specific roles
Pending further discussion, especially regarding the roles that are listed with a "(?)", the following attributes should not be global, or should be noted as prohibited on all applicable roles where they would not be expected.
aria-disabled
should be allowed on:scrollbarseparatorDiscussion point
aria-disabled
could be allowed on the following Document Structure roles as well:Doing so would allow for parity with HTML's allowance of
<fieldset disabled>
. Though allowing on these could also be more trouble than its worth. Really interested to hear what others think.aria-errormessage
andaria-invalid
should be allowed on:checkbox
combobox
listbox
tree
gridcell
radiogroup
searchbox
slider
switch
textbox
aria-controls
should be allowed on:button
checkbox
link
menuitem
(?)menuitemcheckbox
(?)menuitemradio
(?)option
(?)radio
scrollbar
searchbox
slider
spinbutton
switch
tab
textbox
(?)treeitem
(?)Note, #995 may mean
aria-controls
should remain global until a larger discussion on if any redefinition of the attribute should take place so that AT will be more inclined implement it / not ignore it.aria-haspopup
should be allowed on:button
combobox
gridcell
(?)menuitem
searchbox
slider
(?) - datalist is allowed on HTML's input but treated differentlytextbox
treeitem
(?)(edit) Final note:
Whatever is decided here, I'd imagine a good path forward would be to not necessarily act on this as a single issue, but to create sub-issues for any reallocation. Then make PRs on those sub-tasks individually, instead of tackling this all at once.
The text was updated successfully, but these errors were encountered: