Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Several DPUB roles should map to region, not group, so they can be landmarks. #435

Closed
cookiecrook opened this issue Sep 25, 2016 · 9 comments
Assignees

Comments

@cookiecrook
Copy link
Contributor

cookiecrook commented Sep 25, 2016

After discussing with Tzviya at TPAC, these should be direct maps to the region role, not the group role. I previously objected to the custom mappings (new subrole and new role descriptions) on macOS, but I have no issue mapping these to section in order to inherit the landmark functionality.

@cookiecrook cookiecrook changed the title MSeveral DPUB roles should map to section, not group macOS: Several DPUB roles should map to section, not group, so they can be landmarks. Sep 25, 2016
@cookiecrook cookiecrook changed the title macOS: Several DPUB roles should map to section, not group, so they can be landmarks. macOS: Several DPUB roles should map to region, not group, so they can be landmarks. Sep 25, 2016
@cookiecrook
Copy link
Contributor Author

doc-toc should probably map to navigation

@cookiecrook
Copy link
Contributor Author

Working on a PR. @TzviyaSiegman, if you think doc-index, doc-pagelist, or others should be mapped to navigation, let me know.

@cookiecrook cookiecrook self-assigned this Sep 26, 2016
@cookiecrook
Copy link
Contributor Author

PR #436 closes Issue #435

@TzviyaSiegman
Copy link
Contributor

@cookiecrook, thank you.
We had indicated that doc-index subclasses directory or landmark, not navigation. I am not sure what this means for mappings. Happy to discuss.
doc-pagelist](https://www.w3.org/TR/dpub-aria-1.0/#doc-pagelist) is a subclass of navigation and should be mapped to navigation.
I agree that doc-toc should be navigation.
cc: @mattgarrish

@cookiecrook
Copy link
Contributor Author

Thanks Tzviya. Merged branch into master.

@mattgarrish
Copy link
Member

@TzviyaSiegman we changed all the navigation roles definitions to say "navigation aid" and changed their superclasses to navigation. Seeing doc-index in the vocabulary with the updated definition but directory and landmark superclasses looks like a mistake to me.

@richschwer
Copy link
Contributor

I updated the dpub.html document and made changes to reflect the navigation role in dpub-aam for MacOSX. James reviewed those changes.

@cookiecrook
Copy link
Contributor Author

@richschwer Will you post the link to that PR?

@richschwer
Copy link
Contributor

pkra pushed a commit that referenced this issue May 20, 2024
…ary element (#435)

* revise allowed attributes on summary element

Normative follow-on from #434

The spec was updated to note that the summary element doesnt' always map to the button element.  The allowed attributes indicated that all attributes that were applicable to the button role were allowed.  However, in practice this doesn't make sense and could break or be in contradiction to the implicit semantics.

The allowed aria-* attributes for the button role include 
* aria-disabled
* aria-haspopup
* aria-expanded
* aria-pressed

Of those four, aria-expanded and pressed are the ones that would pose problems by conflicting or not making any sense with the implicit expanded/collapsed states provided by the element (who gets the state per the parent details having an open attribute or not).

* further clarifications for summary element allowances
this addition to the PR takes into account that only a summary element that serves as the 'summary for its parent details' needs to adhere to these rules.
otherwise, a summary element that doesn't meet the criteria of the HTML spec is essentially just a generic element, so any roles/attributes can be used on that.


* updated changelog
pkra pushed a commit that referenced this issue May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants