Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some behavior bugs and added documentation for aria-disabled on font smaller and larger; also fixed the aria-expanded bug with link menubar and second level popups #448

Merged
merged 4 commits into from
Oct 11, 2017

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Aug 28, 2017

fixed bugs in:

  1. Italic style menu button did not toggle off italics and now it does
  2. Activating the font larger or smaller menu item was not updating the list of menubuttonradio items for font size and now there are updated
  3. Updated documentation to include information about the use of aria-disabled for the font smaller and larger options

@jongund jongund changed the title Fixed some behavior bugs and added documentation for aria-disabled on font smaller and larger Fixed some behavior bugs and added documentation for aria-disabled on font smaller and larger; also fixed the aria-expanded bug with link menubar and second level popups Oct 11, 2017
@mcking65
Copy link
Contributor

@jongund, thank you.

There were some ESLint errors that I was able to fix automatically so I pushed another commit to your menubar branch.

I am going to squash and merge this so please delete your menubar branch and make a new branch off the latest master for any additional pull requests related to menubar.

The first set of changes look good. However, at least as far as I can tell with JAWS in Firefox 56, issue #472 is not yet fixed. It looks like the parent menuitem for Facts and Campus Tours still have aria-expanded=false even when the submenus are expanded.

@mcking65 mcking65 merged commit 0de93bd into w3c:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants