chore: typo in "nvda" aria-labelledby value #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typo was causing the labelledby to point at the wrong/missing ID
Merged
jnurthen
reviewed
Jul 20, 2017
| @@ -281,4 +281,4 @@ <h2 id="id3">Related W3C Documents</h2> | |||
| </script> | |||
| <script type="text/javascript" src="js/SkipTo.min.js"></script> | |||
| </body> | |||
| </html> | |||
There was a problem hiding this comment.
Can you please use an editor that supports .editorconfig so we get consistent formatting. Files should end in a newline
There was a problem hiding this comment.
I was using the web editor, which does actually support EditorConfig.
This diff is actually saying that I fixed the missing eof newline
There was a problem hiding this comment.
ok... I get it now.... That is confusing of github to add a symbol for a missing newline character ;)
There was a problem hiding this comment.
Yup, that character they use is pretty odd. I resisted commenting the same thing on your last PR 😝
mcking65
added
Example Page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typo was causing the labelledby to point at the wrong/missing ID