updated disclosure examples to restore use of DL/DT/DD and use button element #282
Conversation
…formation and removed the use of DL/DT/DD elements in FAQ example
jongund
changed the title
There was a problem hiding this comment.
Undo change on line 229 of html file; it breaks html source code display.
Changing to div from dt and dd is not better; it removes semantics. I don't think we agreed to do that during the meeting on Monday.
A preferable change is to put buttons inside dt and expandable sections inside dd. Then, the list structure is visible and useful. It is a list of questions, so a list structure is appropriate. And, each element in the list has two parts that map well to dt and dd so the dl is an appropriate type of list.
| @@ -226,7 +226,7 @@ <h2 id="sc1_label">HTML Source Code</h2> | |||
| aria-label="End of" | |||
| ></div> | |||
| <script> | |||
| sourceCode.add('sc1', 'ex1'); | |||
| sourceCode.adiv('sc1', 'ex1'); | |||
There was a problem hiding this comment.
Why this change? It breaks display of source code.
mcking65
changed the title
…n element instead of span elements with role=button
jongund
changed the title
modified: examples/disclosure/disclosure-faq.html: * Moved answers inside of a `p` element inside of the `dd` element. * Fixed call to method for displaying html source. * Editorial revisions.
modified examples/disclosure/disclosure-faq.html: * Revised title and H1 to include the word "Example". modified examples/disclosure/disclosure-img-long-description.html: * Revised title and H1 to include the word "Example". * Change heading inside of example to H3 * Fix typos * Editorial revision to wording of accessibility features for clarity.
|
@jongund, thank you. I made a few more changes and pushed them to this branch. I put the answers to the questions in the FAQ inside of I made some editorial revisions and corrections. I'll merge into master. Please have a look. |
updated example to: