Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treegrid Pattern keyboard section: Correct text for Control + Home/End #2779

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

andrewnicols
Copy link
Contributor

@andrewnicols andrewnicols commented Aug 22, 2023

The text in the treegrid pattern differed to the text in the treegrid example. The content of the treegrid pattern was nonsensical as a column only contains one cell so moving focus to the first cell in a column is meaningless.

The behaviour and text of the example are consistent and make logical sense.

Inaccurate text:
Control + Home: If focus is on a cell, moves focus to the first cell in the column.
Control + End: If focus is on a cell, moves focus to the last cell in the column.

Corrected text:
Control + Home: If focus is on a cell, moves focus to the cell in the first row in the same column as the cell that had focus.
Control + End: If focus is on a cell, moves focus to the cell in the last row in the same column as the cell that had focus.


WAI Preview Link (Last built on Wed, 30 Aug 2023 08:03:27 GMT).

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andrewnicols! I think this is more clear. However, I think there is a typo in ctrl+end. suggestion provided.

content/patterns/treegrid/treegrid-pattern.html Outdated Show resolved Hide resolved
The text in the treegrid pattern differed to the text in the treegrid
example. The content of the treegrid pattern was nonsensical as a column
only contains one cell so moving focus to the first cell in a column is
meaningless.

The behaviour and text of the example are consistent and make logical
sense.

Inaccurate text:
If focus is on a cell, moves focus to the first cell in the column.
If focus is on a cell, moves focus to the last cell in the column.

Corrected text:
If focus is on a cell, moves focus to the cell in the first row in the same column as the cell that had focus.
If focus is on a cell, moves focus to the cell in the last row in the same column as the cell that had focus.
@andrewnicols andrewnicols requested a review from mcking65 August 30, 2023 07:59
@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern labels Sep 19, 2023
@mcking65 mcking65 added this to the ARIA 1.3 Additions milestone Sep 19, 2023
@mcking65 mcking65 changed the title Correct text for Control + Home/End in treegrid pattern Treegrid Pattern keyboard section: Correct text for Control + Home/End Sep 19, 2023
@mcking65 mcking65 added Pattern Page Related to a page documenting a Pattern and removed Example Page Related to a page containing an example implementation of a pattern labels Sep 19, 2023
@mcking65 mcking65 merged commit 3b17ee7 into w3c:main Sep 19, 2023
2 of 3 checks passed
@mcking65
Copy link
Contributor

Thank you @andrewnicols for the fix!! It will go live in the next publication, which is typically at the end of the month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Pattern Page Related to a page documenting a Pattern
Development

Successfully merging this pull request may close these issues.

2 participants