-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing example adding select and input elements to the treegrid example #2748
Open
jongund
wants to merge
7
commits into
main
Choose a base branch
from
test/treegrid-select
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongund
changed the title
added select and input elements to the treegrid
Testing example adding select and input elements to the treegrid example
Jul 12, 2023
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<Jem> Topic:Supporting selects in treegrid cells<Jem> github:https://github.com//pull/2741 <Jem> jon: it does not do what documentation said. <Jem> Matt_King: you include one change to this PR in order to do that. <Jem> jongund: adding select box to list and input type text. <Jem> s/box/ / <Jem> github:https://github.com//pull/2748 <Jem> Matt_King: we asked jon to test PR 2741. <Jem> ..PR 2741 will make the user stuck with adding select <Jem> ... current tree grid example does not support select, edit inside of tree grid. <Jem> .. the work scope of 2748 will be larger than 2741 <Jem> ...current approach - focus in the grid cell, choose the select, and so on. there is a lot of questions which are not answered here. How do you indicate how you escape the selection, how to indicate the focus is out. <Jem> jon: tab feature is working correctly as described the way the tab should work for now. <CurtBellew> At Oracle we set the keyboard users focus on the gridcell when there is a text input for example. Enter or F2 sets focus in the input. Enter or F2 sets focus back to the gridcell <Jem> discussing arrow key behavior in select <Jem> arrow is trapped. <Jem> left and right arrow key is trapped in select <Jem> up and down arrow key are working but it put you in different select box. <Jem> Matt_King: may be 2741 is enough to support select <Jem> Matt_King: bryan mentioned that arrow works with browser supported. <Jem> Matt_King: what do you think about adding select to edit in the grid? <jongund> https://deploy-preview-241--aria-practices.netlify.app/aria/apg/patterns/treegrid/examples/treegrid-1/ <Jem> NVDA tells what row and column I am unlike Jaws <Jem> s/what/in which/ <jongund> I have to leave a little early, good discussion <Jem> The discussion summary today will be added to 2741. <Jem> Matt_King: I have the direction for the select in the grid now after the discussion. This is great. <Jem> rrsagent, make minutes <RRSAgent> I have made the request to generate https://www.w3.org/2023/08/08-aria-apg-minutes.html Jem <Jem> rrsagent, make minutes <RRSAgent> I have made the request to generate https://www.w3.org/2023/08/08-aria-apg-minutes.html Jem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview link to modified grid with input and select in each row
NOTE: Visual rendering creates a horizontal scroll in modified example.
WAI Preview Link of APG Home Page (Last built on Tue, 11 Jul 2023 20:19:39 GMT).
WAI Preview Link (Last built on Tue, 08 Aug 2023 18:24:42 GMT).