Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feed Example Display Page: Change h2 to h1 #2120

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Feed Example Display Page: Change h2 to h1 #2120

merged 1 commit into from
Nov 14, 2021

Conversation

WilcoFiers
Copy link
Contributor

Replace the h2 with an h1. There's no reason for that first heading to be an h2.

mcking65
mcking65 approved these changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @WilcoFiers. LGTM.

@mcking65 mcking65 changed the title FeedDisplay: Pages should have an h1 Feed Example Display Page: Change h2 to h1 Nov 14, 2021
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern QA for APG Examples Related to improve the quality and the acceptance of APG examples labels Nov 14, 2021
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Nov 14, 2021
@mcking65 mcking65 merged commit 742e1ca into w3c:main Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

Assignees
No one assigned
Labels
Example Page Related to a page containing an example implementation of a pattern QA for APG Examples Related to improve the quality and the acceptance of APG examples
Projects
Feed Pattern and Examples Development Project
Status: Complete
Milestone
1.2 Release 1
Development

Successfully merging this pull request may close these issues.
2 participants
@WilcoFiers @mcking65