Infrastructure: Update Stylelint #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
commented
Oct 30, 2021
| @@ -17,6 +17,8 @@ | |||
| ] | |||
| }, | |||
| ], | |||
| "selector-class-pattern": null, | |||
There was a problem hiding this comment.
These are the suppress issues
examples/css/github.css
77:1 ✖ Expected class selector to be kebab-case selector-class-pattern
examples/dialog-modal/css/dialog.css
30:1 ✖ Expected class selector to be kebab-case selector-class-pattern
34:1 ✖ Expected class selector to be kebab-case selector-class-pattern
38:1 ✖ Expected class selector to be kebab-case selector-class-pattern
38:14 ✖ Expected class selector to be kebab-case selector-class-pattern
48:1 ✖ Expected class selector to be kebab-case selector-class-pattern
48:14 ✖ Expected class selector to be kebab-case selector-class-pattern
57:1 ✖ Expected class selector to be kebab-case selector-class-pattern
62:1 ✖ Expected class selector to be kebab-case selector-class-pattern
62:19 ✖ Expected class selector to be kebab-case selector-class-pattern
68:1 ✖ Expected class selector to be kebab-case selector-class-pattern
68:19 ✖ Expected class selector to be kebab-case selector-class-pattern
74:1 ✖ Expected class selector to be kebab-case selector-class-pattern
74:19 ✖ Expected class selector to be kebab-case selector-class-pattern
80:1 ✖ Expected class selector to be kebab-case selector-class-pattern
80:19 ✖ Expected class selector to be kebab-case selector-class-pattern
86:1 ✖ Expected class selector to be kebab-case selector-class-pattern
91:1 ✖ Expected class selector to be kebab-case selector-class-pattern
99:1 ✖ Expected class selector to be kebab-case selector-class-pattern
103:1 ✖ Expected class selector to be kebab-case selector-class-pattern
examples/grid/css/layoutGrids.css
20:3 ✖ Expected class selector to be kebab-case selector-class-pattern
25:1 ✖ Expected class selector to be kebab-case selector-class-pattern
105:1 ✖ Expected class selector to be kebab-case selector-class-pattern
127:1 ✖ Expected id selector to be kebab-case selector-id-pattern
172:1 ✖ Expected class selector to be kebab-case selector-class-pattern
178:1 ✖ Expected class selector to be kebab-case selector-class-pattern
182:1 ✖ Expected class selector to be kebab-case selector-class-pattern
examples/listbox/css/listbox.css
19:17 ✖ Expected id selector to be kebab-case selector-id-pattern
examples/slider/css/slider-color-viewer.css
51:15 ✖ Expected class selector to be kebab-case selector-class-pattern
nschonni
force-pushed
the
update-stylelint
branch
from
2d3ef5c to
fced00e
Compare
|
@mcking65 the diff is a little ugly, so summarizing the changes a bit:
|
nschonni
force-pushed
the
update-stylelint
branch
2 times, most recently
from
4b7aeb2 to
c44ef2c
Compare
zcorpan
approved these changes
Nov 2, 2021
| @@ -1,7 +1,7 @@ | |||
| .accordion { | |||
| margin: 0; | |||
| padding: 0; | |||
| border: 2px solid hsl(0, 0%, 52%); | |||
| border: 2px solid hsl(0deg 0% 52%); | |||
There was a problem hiding this comment.
Should we change https://github.com/w3c/aria-practices/wiki/Code-Guide#syntax-1 to say to use spaces instead of commas in rgb(), hsl() et. al.?
There was a problem hiding this comment.
It can be autofixed to either "modern" (spaces) or "legacy" (commas)
https://stylelint.io/user-guide/rules/list/color-function-notation
Support seems pretty good, so I think we can go with "modern".
https://caniuse.com/mdn-css_types_color_rgb_function_accepts_alpha
There was a problem hiding this comment.
Yeah, I autofixed the bulk of this using whatever the default is by the preset
There was a problem hiding this comment.
I think we can merge this. Updating the wiki is tracked in #2110
zcorpan
added
the
Infrastructure
Autofix and address most new rules. Ignore the kebab case rules
nschonni
force-pushed
the
update-stylelint
branch
from
c44ef2c to
ad5557d
Compare
|
@howard-e can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autofix and address most new rules.
Ignore the kebab case rules