Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: Move husky install to prepare script #2033

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Infrastructure: Move husky install to prepare script #2033

merged 1 commit into from
Oct 29, 2021

Conversation

WilcoFiers
Copy link
Contributor

It is no longer recommended to use "postinstall" for Husky (see docs), and to use "prepare" instead. postinstall scripts can not be guaranteed to run, and make it impossible to aria-practices into another project. The following will throw an error, because the postinstall is used rather than prepare:

$ npm install -D w3c/aria-practices#main
> [email protected] postinstall /Users/wilco/projects/axe-core/node_modules/aria-practices
> husky install

sh: husky: command not found

@WilcoFiers WilcoFiers mentioned this pull request Sep 3, 2021
Merged
4 tasks
@mcking65 mcking65 changed the title Move husky install to prepare script Infrastructure: Move husky install to prepare script Oct 4, 2021
@mcking65 mcking65 added the Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation label Oct 4, 2021
@mcking65 mcking65 requested a review from jesdaigle October 4, 2021 18:28
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Oct 4, 2021
@WilcoFiers
Copy link
Contributor Author

WilcoFiers commented Oct 8, 2021 •
edited
Loading

@jesdaigle Any idea when this could go in? If not, I can work from a fork, but I would prefer not to if I can avoid that.

@mcking65 mcking65 removed this from the 1.2 Release 1 milestone Oct 17, 2021
zcorpan
zcorpan approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, CI checks are now green. The change LGTM, thanks!

@howard-e howard-e merged commit c9ecd4a into w3c:main Oct 29, 2021
@a11ydoer
Copy link
Contributor

@WilcoFiers please confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcorpan zcorpan zcorpan approved these changes

@jesdaigle jesdaigle Awaiting requested review from jesdaigle

Assignees
No one assigned
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WilcoFiers @a11ydoer @zcorpan @howard-e @mcking65