Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch example using HTML checkbox input #1895
Add switch example using HTML checkbox input #1895
Changes from 63 commits
97f74a9
02e388c
91aeb0b
c00b665
7f943cc
77abf1d
a32ebb7
27f2ebe
bf5ded6
2d403bc
218de1f
8e5f3be
e73bc13
a7b41e3
e7d7788
1d86f3f
6b61219
48851af
2ca24b8
813cbf1
02da47b
063e4a7
4b3f267
60ebb9f
0308ff2
93d8996
4456f7e
399fbc1
50cf98b
85041af
41a801c
dd2535a
4372458
80e26b0
a60b782
197e98a
b05cace
bf32c6f
e0b872f
ef6a773
1b3f2c7
4334d0e
499acde
c6e44db
66b6a55
1a009fc
6044a71
47041ce
13351af
7211c39
b761845
88733e1
ac426b1
9c8fae3
b613279
5d41df7
fcc1cc4
2b088d8
f31b97c
2e7ee8b
de13911
562fe03
13face8
558fc72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't follow https://github.com/w3c/aria-practices/wiki/Code-Guide#prefixed-properties
Should we remove that section of the code guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zcorpan based on our Nov 2 discussion,I think we still need this for webkit. I think @jongund is looking into whether the others can be removed from this example without issue. Do we need a separate issue for conversation about what to do for prefix guidance in the code guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can track it in #2110