Jump To Content: Add menu button to examples to implement WCAG bypass blocks requirement #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongund
changed the title
jongund
changed the title
a11ydoer
requested review from
smhigley and
shirsha
and removed request for
carmacleod and
charmarkk
…esome for Icon (pull #1685) 1. Adds font awesome icon stylesheet to Codepen options. Now, if font awesome is used in an example going forward, the icons will appear as expected when the example is opened in codepen. 2. Adds the Open In Codepen button to the two examples that use font awesome already: toolbar/toolbar.html and dialog-modal/datepicker-dialog.html. 3. Converts the treeview directory example to use font awesome icons for the folder and file icons and adds the "Open in Codepen" button to them: treeview/treeview-1/treeview-1a.html and treeview/treeview-1/treeview-1b.html
…scripts (pull #1859) Updates the scripts that generate the example index and coverage reports: * Updated list of roles to include new roles in ARIA 1.2: * caption * code * deletion * emphasis * generic * input * insertion * meter * paragraph * Fixed bug in aria-label also getting references to aria-labelledby , by using a regex, and this was also applied to checking roles. * Updated code to use node-html-parser for identify the roles, properties and states associated with an example, making the code much easier to read and understand. * Added the identification of examples with specific high contrast support features. * Updated coverage report to provide more information on example quality assurance. * Add a coding practices section to the coverage report to monitor implementation of APG coding practices.
|
@mcking65 |
…t affected this pull request, but it was failing even when no menu button example file was touched
|
We will talk about this at APG meeting on May 25, 2021. I also assigned reviewers. |
|
Update code:
NOTE: JAWS and NVDA on Windows and VoiceOver on macOS announcement shortcut key from the accesskey attribute information. |
Merged
8 tasks
|
This pull request has been moved to pull #1923. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
jumpto.jsapp.jsto add the appropriate reference to each example.preview link for index of examples
preview link for button example
preview link for checkbox 1 example