-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warning to Collapsible Listbox example #1852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks, @smhigley !
Approving whether or not the little suggested change is included.
The deprecation warning looks good. I think we should also remove the link to the collapsable listbox example from:
I'd like to discuss whether we note deprecation in the main document or remove the link. I'm leaning toward removing the link. We might also want to put something in the metadata, perhaps a data attribute on the H1, that would tell the indexing code to ignore it. Also, what about adding "(Deprecated)" to the beginning of the page title tag and the start of the H1? Hmm, maybe that could be the indicator to the indexing script. |
APG groupd made a decision to remove deprecated examples on May 4, 2021 |
Note to self:
|
@smhigley @mcking65 @a11ydoer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smhigley
I think this pull request should just delete the listbox-collapsible.html
reference in aria-practices.html
and not add the new reference to listbox-select-only.html
.
The pull request that creates listbox-select-only.html
should make it's own changes to aria-practices.html
and listbox-collapsible.html
so the links actually work, otherwise as a reviewer it is confusing.
@jongund the added link is for the already-existing |
@smhigley |
…d deprecation warning to example page
Co-authored-by: Carolyn MacLeod <[email protected]>
fea238e
to
70eea1d
Compare
@@ -2,7 +2,7 @@ | |||
<html lang="en"> | |||
<head> | |||
<meta charset="utf-8" /> | |||
<title>Listbox Example with Grouped Options | WAI-ARIA Authoring Practices 1.2</title> | |||
<title>(Deprecated) Listbox Example with Grouped Options | WAI-ARIA Authoring Practices 1.2</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, right change in wrong file :) I'll push a fix for this.
@@ -26,7 +26,7 @@ | |||
</ul> | |||
</nav> | |||
<main> | |||
<h1>Listbox Example with Grouped Options</h1> | |||
<h1>(Deprecated) Listbox Example with Grouped Options</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this one too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, Looks good now. Thank you @smhigley!
Resolves #657
Includes the following two changes:
Preview link for example page
Preview | Diff