Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: Combine ESLint config at root #1602

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Infrastructure: Combine ESLint config at root #1602

merged 3 commits into from
Dec 1, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 9, 2020

Pull settings from child .eslintrc.json files into "overridess" section
at root.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Regression test coverage:

Examples without any regression tests:

  • dialog-modal/alertdialog.html

Examples missing some regression tests:

  • dialog-modal/datepicker-dialog.html:
    • textbox-aria-describedby
  • menu-button/menu-button-actions-active-descendant.html:
    • menu-up-arrow
    • menu-down-arrow
    • menu-character
  • toolbar/toolbar.html:
    • toolbar-tab
    • toolbar-right-arrow
    • toolbar-left-arrow
    • toolbar-home
    • toolbar-end
    • toolbar-toggle-esc
    • toolbar-toggle-enter-or-space
    • toolbar-radio-enter-or-space
    • toolbar-radio-down-arrow
    • toolbar-radio-up-arrow
    • toolbar-button-enter-or-space
    • toolbar-menubutton-enter-or-space-or-down-or-up
    • toolbar-menu-enter-or-space
    • toolbar-menu-down-arrow
    • toolbar-menu-up-arrow
    • toolbar-menu-escape
    • toolbar-spinbutton-down-arrow
    • toolbar-spinbutton-up-arrow
    • toolbar-spinbutton-page-down
    • toolbar-spinbutton-page-up
    • toolbar-checkbox-space
    • toolbar-link-enter-or-space
    • toolbar-spinbutton-role

Example pages with Keyboard or Attribute table rows that do not have data-test-ids:

  • dialog-modal/alertdialog.html
    • "Keyboard Support" table(s):
      • Tab
      • Shift + Tab
      • Escape
      • Command + S
      • Control + S
    • "Attributes" table(s):
      • alertdialog
      • aria-labelledby=IDREF
      • aria-describedby=IDREF
      • aria-modal=true
      • alert

SUMMARY:

55 example pages found.
1 example pages have no regression tests.
3 example pages are missing approximately 27 out of approximately 780 tests.

ERROR - missing tests:

Please write missing tests for this report to pass.

nschonni
nschonni commented Nov 9, 2020
View reviewed changes
.eslintrc.json
},
"extends": ["plugin:ava/recommended"],
"env": {
"node": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spectranaut I added this for the no-undef for later

@nschonni nschonni force-pushed the eslint-root-config branch 3 times, most recently from 1284350 to 0739a7b Compare November 9, 2020 18:52
@nschonni
Copy link
Contributor Author

nschonni commented Nov 9, 2020

@mcking65 @spectranaut I pushed down the 2 current suppressed rules to "overrides" as well.
This fixes #1429 till the individual violations are addressed, but will prevent new ones as examples are updated/renamed

@nschonni nschonni mentioned this pull request Nov 11, 2020
Merged
spectranaut
spectranaut approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I think this is a useful clean up -- much nice to have this all in one file.

.eslintrc.json
"test/tests/treeview_treeview-2b.js",
"test/util/assertAriaDescribedby.js",
"test/util/assertDotValue.js",
"test/util/report.js"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clever! :) Do we have a backlog issue for this to track it's fix/removal? Because it's a bit awkward to leave in in the long run. The "no-undef" below has that open PR, which essentially tracks the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: I just saw #1610 -- invalidating this comment because you are fixing all the undefs, unused vars. awesome :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this could always land first so no new ones sneak in, while the other one is evaluated to see if broke anything 😆

@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation labels Dec 1, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Dec 1, 2020
@mcking65 mcking65 merged commit f54c176 into w3c:master Dec 1, 2020
@nschonni nschonni deleted the eslint-root-config branch December 1, 2020 00:43
@Clemens-git76 Clemens-git76 mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spectranaut spectranaut spectranaut approved these changes

Assignees
No one assigned
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Milestone
1.2 Release 1
Development

Successfully merging this pull request may close these issues.
3 participants
@nschonni @spectranaut @mcking65