Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ok but we could consider changing this to match the other discretionary roles which describe why you might want to give it an accessible name. However - I'm not sure I can really come up with a valid use case for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's valid to give a marquee a name, just didn't make sense to require it.
I very quickly tested 4 marquees using jaws/nvda in chrome/ff.
Notes:
<marquee>
elements. One hasaria-labelledby
and the other hasaria-label
.aria-labelledby
and the other hasaria-label
.role="marquee"
("belts and braces" style) on the 2 HTML<marquee>
elements (otherwise, they just had a generic text container role).aria-live="off"
.aria-labelledby
span, because it's visible text content. :)aria-label
.So we could say something along the lines of, "When naming a marquee,
aria-labelledby
with a visible label is recommended, because some screen readers do not read anaria-label
on a marquee."I'll try Safari/VO tomorrow.
Edit: Safari/VO reads all 4 marquees well (using VO+arrows), and even reads the name of the 2
aria-label
marquees. The explicit role was also needed on the obsolete html marquee elements (same as Chrome/FF).