-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure: Switch HTML linting to GitHub Actions #1523
Conversation
This comment has been minimized.
This comment has been minimized.
aca3aaa
to
ea4184c
Compare
ea4184c
to
e645946
Compare
298537d
to
a58ff82
Compare
49eb308
to
0eda1c0
Compare
0ca08d6
to
0fc10d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one question!
"line": 2, | ||
"column": 3, | ||
"severity": 4, | ||
"message": 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is so cool can't wait to see it in action!
Looks like you deleted the travis file after all, what changed? Was the policy updated, should we close this? #1548 edit: Oh I see the that travis is still required below. So we have to leave in the file or update the policy still. |
0fc10d9
to
f4c6e52
Compare
@nschonni |
e80a020
to
0a3ace7
Compare
@mcking65 I've rebased this and it's showing the HTML linting check now in addition to the stuck Travis one. If you just want to land this and don't have the permissions to update the policy, I can leave the Travis file un-deleted, but not running anything for a future PR to delete it |
@nschonni |
0a3ace7
to
981f088
Compare
@mcking65 OK, I've made the Travis |
thank you @nschonni! |
Moves Travis-CI job to GitHub Actions, and adds a problem matcher so errors are identified inline on the files tab of PRs