Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Switch HTML linting to GitHub Actions #1523

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Sep 9, 2020

Moves Travis-CI job to GitHub Actions, and adds a problem matcher so errors are identified inline on the files tab of PRs

.vnurc Outdated Show resolved Hide resolved
@nschonni

This comment has been minimized.

@nschonni nschonni changed the title chore: Switch HTML linting to GitHub Actions Infrastructure: Switch HTML linting to GitHub Actions Sep 29, 2020
@nschonni nschonni marked this pull request as ready for review September 29, 2020 15:09
@nschonni nschonni force-pushed the hmtl-github-action branch 2 times, most recently from 298537d to a58ff82 Compare September 29, 2020 17:13
@nschonni nschonni force-pushed the hmtl-github-action branch 2 times, most recently from 49eb308 to 0eda1c0 Compare September 30, 2020 20:15
@nschonni
Copy link
Contributor Author

@mcking65 I have keep the Travis file to make this pass, or the branch policies can be updated as I mentioned in #1548

@nschonni nschonni force-pushed the hmtl-github-action branch 4 times, most recently from 0ca08d6 to 0fc10d9 Compare October 2, 2020 17:38
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question!

.github/workflows/lint-html.yml Show resolved Hide resolved
"line": 2,
"column": 3,
"severity": 4,
"message": 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so cool can't wait to see it in action!

@spectranaut
Copy link
Contributor

spectranaut commented Oct 8, 2020

@mcking65 I have keep the Travis file to make this pass, or the branch policies can be updated as I mentioned in #1548

Looks like you deleted the travis file after all, what changed? Was the policy updated, should we close this? #1548

edit: Oh I see the that travis is still required below. So we have to leave in the file or update the policy still.

@mcking65
Copy link
Contributor

@nschonni
I don't understand what is going on with this PR. There are no checks! Yet, travis is required. GitHub is waiting for travis to report a status, but how would it ever do so? It doesn't seem possible to merge this.

@nschonni
Copy link
Contributor Author

@mcking65 I've rebased this and it's showing the HTML linting check now in addition to the stuck Travis one.
For the Travis part, someone with administrator access needs to go into the branch policy and mark Travis as no longer required as described in #1548

If you just want to land this and don't have the permissions to update the policy, I can leave the Travis file un-deleted, but not running anything for a future PR to delete it

@mcking65
Copy link
Contributor

@nschonni
I think that's how we should do it ... reduce travis to no-op first, then delete in a separate PR.

@nschonni
Copy link
Contributor Author

@mcking65 OK, I've made the Travis install and script no-op. It can be removed once the policy is updated, but this PR can land now

@mcking65 mcking65 merged commit 6485d4c into w3c:master Oct 21, 2020
@mcking65
Copy link
Contributor

thank you @nschonni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants