-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add queryElement test helper function #1486
Conversation
7981378
to
3a785be
Compare
@spectranaut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm wondering if I should have named queryElements
to make it more obvious that it failed if no elements were found, and to differentiate more meaningfully from findElement(s)
😅.
This looks fine though. Is it mostly just to provide parity with queryElements
, so test authors aren't confused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this change effect current regression tests and the regression tests in pull request?
How will linting to make using findElement failing?
OK, thank you @spectranaut and @smhigley, this seems ready to go. @jongund , it appears that it won't cause any disruption of work for you. I will merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the status of how this change affects existing pull requests.
@spectranaut @smhigley |
This PR fulfills the request from issue #1403 to have a
queryElement
helper function that is analogous toqueryElements
. It also replaces all the calls ofqueryElements
when only the first element is needed.