Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs Pattern: Revise tabpanel tabindex guidance for issue 1164 #1274

Merged
merged 6 commits into from
Jan 23, 2020
Merged

Tabs Pattern: Revise tabpanel tabindex guidance for issue 1164 #1274

merged 6 commits into from
Jan 23, 2020

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Nov 20, 2019 •
edited by pr-preview bot
Loading

To resolve #1164, revises the Tab key guidance for tabbing out of the tablist and to the tabpanel.

Preview | Diff

@mcking65 mcking65 changed the title Issue1164 tabpanel tabindex guidance Tabs Pattern: Revise tabpanel tabindex guidance for issue 1164 Dec 11, 2019
mcking65
mcking65 approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believes this resolves the issue. Thank you @jongund.

@mcking65 mcking65 mentioned this pull request Dec 11, 2019
Closed
@mcking65 mcking65 merged commit eb5bc34 into master Jan 23, 2020
@mcking65 mcking65 deleted the issue1164-tabpanel-tabindex-guidance branch January 23, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

@carmacleod carmacleod carmacleod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs pattern needs to say whether tabpanel should take focus
3 participants
@jongund @carmacleod @mcking65