-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datepicker based on dialog pattern for issue 1046 #1054
Conversation
* Change title tag and H1 * Remove some references to menubutton in text (did not change example code or documentation tables) * rename datepicker-menubutton.js to datepicker-button.js
Found a user interaction bug: If you click on the calendar icon, the dialog opens but focus remains on the calendar icon. |
Typically clicking on a button moves focus to the button, not somewhere else. Since the user clicked on the button to open the dialog, mostly likely they will be using the mouse to select a date. But it is something we should ask Matt about to see if he thinks it is something the group should discuss and review. |
… reference, moves focus to dialog when click on button
…escribedby from calendar button, started to move dialog status message to be inside the dialog box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jongund, It's working much better after the last set of commits. I found a few more things to change.
@jongund, I pushed a few changes to the introduction. One other change that I didn't include in my review ... currently the button is named "Calendar". I think we should change it to "Choose Date". |
… the cursor keye, also elimintated a number of event handlers assocaited with a combobox pattern
…ctices into issue1046-datepicker-dialog
@mcking65 @spectranaut @a11ydoer I have made the changes requested yesterday and in the pull request to the datepicker dialog example so it should be ready for review and adding additional regression tests |
…th other references to the same file.
@jnurthen, thank you for the review and edits!! We're ready to ship this one. |
Adds date picker dialog example to the modal-dialog directory for issue #1046.
Preview Link
Preview link for datepicker dialog
Preview | Diff