Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datepicker based on dialog pattern for issue 1046 #1054

Merged
merged 56 commits into from
Jul 11, 2019

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Jun 27, 2019

Adds date picker dialog example to the modal-dialog directory for issue #1046.

Preview Link

Preview link for datepicker dialog


Preview | Diff

@spectranaut
Copy link
Contributor

Found a user interaction bug: If you click on the calendar icon, the dialog opens but focus remains on the calendar icon.
This is mostly odd because a user might click the date then try using left/right arrows, but you still have to type "ENTER" or "SPACE" or "DOWN ARROW" before the focus will move from the icon (even though the dialog is open). The date is also not in the tab sequence until you send on of those keys.

@jongund
Copy link
Contributor Author

jongund commented Jul 2, 2019

Typically clicking on a button moves focus to the button, not somewhere else. Since the user clicked on the button to open the dialog, mostly likely they will be using the mouse to select a date.

But it is something we should ask Matt about to see if he thinks it is something the group should discuss and review.

jongund added 2 commits July 2, 2019 14:30
… reference, moves focus to dialog when click on button
…escribedby from calendar button, started to move dialog status message to be inside the dialog box
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jongund, It's working much better after the last set of commits. I found a few more things to change.

examples/dialog-modal/datepicker-dialog.html Outdated Show resolved Hide resolved
examples/dialog-modal/datepicker-dialog.html Outdated Show resolved Hide resolved
examples/dialog-modal/datepicker-dialog.html Outdated Show resolved Hide resolved
@mcking65 mcking65 changed the title Issue1046 datepicker dialog Add datepicker based on dialog pattern for issue 1046 Jul 2, 2019
@mcking65
Copy link
Contributor

mcking65 commented Jul 2, 2019

@jongund, I pushed a few changes to the introduction.

One other change that I didn't include in my review ... currently the button is named "Calendar". I think we should change it to "Choose Date".

@jongund
Copy link
Contributor Author

jongund commented Jul 3, 2019

@mcking65 @spectranaut @a11ydoer I have made the changes requested yesterday and in the pull request to the datepicker dialog example so it should be ready for review and adding additional regression tests

@mcking65 mcking65 self-assigned this Jul 11, 2019
@mcking65
Copy link
Contributor

@jnurthen, thank you for the review and edits!! We're ready to ship this one.

@mcking65 mcking65 merged commit c55e152 into master Jul 11, 2019
@mcking65 mcking65 deleted the issue1046-datepicker-dialog branch July 11, 2019 18:17
michael-n-cooper pushed a commit that referenced this pull request Jul 11, 2019
Add datepicker based on dialog pattern for issue 1046 (pull #1054)

To resolve issue #1046, adds a modal dialog example that implements a date picker.
The modal dialog includes a calendar grid that implements the grid pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants