Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Carousel Example: Use buttons for controls and make rotation control always visible #1018

Merged
merged 27 commits into from
Jul 11, 2019
Merged

Image Carousel Example: Use buttons for controls and make rotation control always visible #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
91705c2
added visable pause button and converted a elements to button elements
jongund Mar 24, 2019
b903d69
fixed pause button positioning issue
jongund Mar 24, 2019
e8e5c84
updated code to improve color contrast and button positioning
jongund Mar 25, 2019
4cf22c6
fixed css issue
jongund Mar 25, 2019
3656116
fixed css issue
jongund Mar 25, 2019
afbd4c6
updated color contrast of text and positining of controls
jongund Mar 27, 2019
87af5ee
Merge branch 'master' into issue1007-visible-pause-carousel
mcking65 Apr 23, 2019
5e3bbf5
Merge branch 'master' into issue1007-visible-pause-carousel
jongund May 7, 2019
753f8ba
updated carousel example
jongund May 14, 2019
b6c2127
updated carousel documentation
jongund May 14, 2019
84431b5
Merge branch 'master' into issue1007-visible-pause-carousel
mcking65 May 28, 2019
6604f1e
Merge branch 'master' into issue1007-visible-pause-carousel
jongund Jun 21, 2019
d8899a3
added view with controls outside the image
jongund Jun 21, 2019
a637155
updated documentation
jongund Jun 21, 2019
4698b3e
Fix tests, add two attribute tests
Jul 1, 2019
1506986
Add remaining keyboard tests
Jul 2, 2019
72230ce
fixed aria-live region update problem and changed group label to use …
jongund Jul 3, 2019
23be6c3
Merge branch 'master' into issue1007-visible-pause-carousel
mcking65 Jul 8, 2019
7703c53
Fix tests from change in example
Jul 8, 2019
e1e6af4
Fix flacky test
Jul 8, 2019
cc5c38d
Merge branch 'master' into issue1007-visible-pause-carousel
mcking65 Jul 11, 2019
ec03e04
Remove link to feedback issue
mcking65 Jul 11, 2019
cf6cbc0
Editorial revisions to introduction
mcking65 Jul 11, 2019
a35dc86
Editorial revisions to accessibility features, remove keyboard info a…
mcking65 Jul 11, 2019
8044e13
Add live region information to accessibility features section.
mcking65 Jul 11, 2019
0611f09
Remove feedback link from carousel pattern section.
mcking65 Jul 11, 2019
e6b4bb5
Merge branch 'master' into issue1007-visible-pause-carousel
mcking65 Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions aria-practices.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,11 +480,6 @@ <h4>WAI-ARIA Roles, States, and Properties</h4>

<section class="widget" id="carousel">
<h3>Carousel (Slide Show or Image Rotator)</h3>
<p>
<strong>NOTE:</strong> This is a new pattern as of the January 2019 release of WAI-ARIA Authoring Practices 1.1.
Please provide feedback in
<a href="https://github.com/w3c/aria-practices/issues/970">issue 970.</a>
</p>
<p>
A carousel presents a set of items, referred to as slides, by sequentially displaying a subset of one or more slides.
Typically, one slide is displayed at a time, and users can activate a next or previous slide control that hides the current slide and &quot;rotates&quot; the next or previous slide into view.
Expand Down
218 changes: 117 additions & 101 deletions examples/carousel/carousel-1/carousel-1.html → examples/carousel/carousel-1.html
View file
Open in desktop

Large diffs are not rendered by default.

176 changes: 0 additions & 176 deletions examples/carousel/carousel-1/css/carousel.css
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions examples/carousel/carousel-1/js/pauseButton.js
View file
Open in desktop

This file was deleted.

Loading