Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in documentation combobox/aria1.1pattern/grid-combo.html: "aria-selected" on row or gridcell? #859

Closed
spectranaut opened this issue Aug 27, 2018 · 1 comment
Closed

Bug in documentation combobox/aria1.1pattern/grid-combo.html: "aria-selected" on row or gridcell? #859

spectranaut opened this issue Aug 27, 2018 · 1 comment
Labels
Example Page Related to a page containing an example implementation of a pattern Inaccuracy Incorrect statement in prose (not a code bug)
Milestone
1.2 Release 1

Comments

@spectranaut
Copy link
Contributor

On the grid-combo example, the "Grid Popup" attribute table describes the "aria-selected" attribution as:

  • Specified on a row in the grid when it is visually indicated as selected.
  • Occurs only when a cell in the grid is referenced by aria-activedescendant.

However, in the example, "aria-selected" is on the gridcell. The attribute is always on the first gridcell (of the gridcell pairs in a single row), so it always indicates the string that will be selected with an "enter" key. Both implementations of "aria-selected" seem valid (the example and the documentation), which on is preferred?
@mcking65 mcking65 added documentation Example Page Related to a page containing an example implementation of a pattern Inaccuracy Incorrect statement in prose (not a code bug) labels Dec 9, 2019
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Dec 9, 2019
@mcking65 mcking65 mentioned this issue Nov 15, 2021
Merged
mcking65 added a commit that referenced this issue Nov 15, 2021
@mcking65
Combobox example with grid popup: Correct documentation of aria-selec…
6d5c495 
…ted (pull #2139)

Resolves issue #859 by clarifying that the grid cell is the element that has aria-selected specified.
@mcking65
Copy link
Contributor

Resolved with #2139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Example Page Related to a page containing an example implementation of a pattern Inaccuracy Incorrect statement in prose (not a code bug)
Projects
None yet
Milestone
1.2 Release 1
Development

No branches or pull requests
2 participants
@spectranaut @mcking65