Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-select accordion implementation #616

Closed
devarshipant opened this issue Mar 12, 2018 · 1 comment · Fixed by #1830
Closed

multi-select accordion implementation #616

devarshipant opened this issue Mar 12, 2018 · 1 comment · Fixed by #1830
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force
Milestone
1.2 Release 1

Comments

@devarshipant
Copy link

Consider giving an example of a multi-select accordion implementation. The current example is based on the requirement:

one panel of the accordion is always expanded, and only one panel may be expanded at a time.

A multi-select example will be useful for users who would like to compare contents of two panels simultaneously opened.
@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force labels Mar 13, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 3 milestone Mar 13, 2018
@carmacleod
Copy link
Contributor

See also #304 (comment)

@mcking65 mcking65 removed this from the 1.1 APG Release 4 milestone Aug 13, 2019
@carmacleod carmacleod mentioned this issue Jul 28, 2020
Open
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Oct 4, 2021
@mcking65 mcking65 linked a pull request Oct 4, 2021 that will close this issue
Update Accordion example code and behavior #1830
Merged
6 tasks
mcking65 pushed a commit that referenced this issue Oct 4, 2021
@smhigley
Accordion Example: Allow any or all sections to expand, clean up styl…
d0299b2 
…es, implement APG code guidelines (pull #1830)

Updates the accordion example to resolve issues #1819, #616, #304, and #1477.

Made the following Behavior changes:
* Removed optional arrow key support.
* Removed requirement forcing one section to always be expanded.
* Removed constraint limiting only one section to be expanded at a time.
* Updated tests to reflect behavior changes.
* Removed section that talked about focus styling for "enhanced keyboard interaction".
* Removed arrow key/home/end rows in example page keyboard table.
* Removed aria-disabled row in example page attributes table.

Code cleanup:
* Updated JS file to a class syntax.
* Update classnames to be lowercase.
* Fix some border-radius issues in focus styling.
* Updated example page wrapper id  attributes to match other example pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force
Projects
Accordion Patterns and Examples Development Project
Status: Complete
Milestone
1.2 Release 1
Development

Successfully merging a pull request may close this issue.

Update Accordion example code and behavior w3c/aria-practices
4 participants
@carmacleod @mcking65 @devarshipant and others