-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Feed Pattern #560
Comments
WAI-ARIA Roles, States, and Properties > fifth bullet: |
No other issues noted. |
I'm guessing that the example review will be opened as a separate issue? |
Per feedback from @annabbott in issue #560, modified the roles, states, and properties subsection of the feed pattern in aria-practices.html to correct a typo in the aria-describedby bullet, changed "Each" to "each".
@annabbott commented:
Fixed in commit 200afa4.
Yes. But, I will be postponing that review and discussion off to the next APG release and marking the current implementation as a proposed implementation that does not yet have task force consensus. |
In this item, "web page code" seems ambiguous, like we're shifting blame to the code rather than the author. I'd prefer "web page author," which does appear elsewhere in the document, including the final paragraph of the feed description. No other issues. |
Hi @mcking65. Thank you so much for the Feed Pattern, it's lovely. I surveyed the other APG patterns (listed after this paragraph) and found considerable use of Navigation keys. In many cases
|
@mendeza asks:
The recommendations for keyboard commands intend to reflect similar conventions. Typically, unmodified home/end stay within a narrowly scoped context where as when modified by control, they make a larger change within the context. For example:
In the context of feed, ctrl+home and ctrl+end are more akin to moving to top of doc and bottom of doc than start of line and end of line. That leaves options for home and end to be used within a smaller context, e.g., start of article and end of article, which are commands we did not define. As a new pattern with no precedent in native Windows, macOS, or Linux, the feed pattern is still somewhat a solution in incubation. That is part of the rationale for keeping this issue open for feedback and questions. |
The feed pattern developed for issue #245 is ready for review.
Task Force Reviews Requested as of December 1, 2017
The text was updated successfully, but these errors were encountered: