Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Feed Pattern #560

Open
1 of 3 tasks
mcking65 opened this issue Dec 1, 2017 · 7 comments
Open
1 of 3 tasks

Review Feed Pattern #560

mcking65 opened this issue Dec 1, 2017 · 7 comments
Assignees
Labels
Pattern Page Related to a page documenting a Pattern

Comments

@mcking65
Copy link
Contributor

mcking65 commented Dec 1, 2017

The feed pattern developed for issue #245 is ready for review.

Task Force Reviews Requested as of December 1, 2017

@mcking65 mcking65 added documentation Pattern Page Related to a page documenting a Pattern labels Dec 1, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 1 milestone Dec 1, 2017
@annabbott
Copy link

WAI-ARIA Roles, States, and Properties > fifth bullet:
Typo:
"It is optional but strongly recommended for Each article element"
Lower case the 'e' in 'each'.

@annabbott
Copy link

No other issues noted.

@annabbott
Copy link

I'm guessing that the example review will be opened as a separate issue?

mcking65 added a commit that referenced this issue Dec 8, 2017
Per feedback from @annabbott in issue #560,
modified the roles, states, and properties subsection of the feed pattern in aria-practices.html
to correct a typo in the aria-describedby bullet, changed "Each" to "each".
@mcking65
Copy link
Contributor Author

mcking65 commented Dec 8, 2017

@annabbott commented:

WAI-ARIA Roles, States, and Properties > fifth bullet:
Typo:
"It is optional but strongly recommended for Each article element"
Lower case the 'e' in 'each'.

Fixed in commit 200afa4.

I'm guessing that the example review will be opened as a separate issue?

Yes. But, I will be postponing that review and discussion off to the next APG release and marking the current implementation as a proposed implementation that does not yet have task force consensus.

@sh0ji
Copy link
Contributor

sh0ji commented Feb 21, 2018

  1. In the context of a feed, the web page code is responsible for:

In this item, "web page code" seems ambiguous, like we're shifting blame to the code rather than the author. I'd prefer "web page author," which does appear elsewhere in the document, including the final paragraph of the feed description.

No other issues.

@mendeza
Copy link

mendeza commented Apr 4, 2024

Hi @mcking65. Thank you so much for the Feed Pattern, it's lovely.
I have a question about adding the Ctrl- modifer to the Home and End keys, e.g., in your document here.

I surveyed the other APG patterns (listed after this paragraph) and found considerable use of Navigation keys. In many cases Home and End are left unmodified. Do you have a strong rationale for using modifiers in the Feed Example, or would you advise leeway and not object to unmodified use? Many thanks for your guidance.

  1. https://www.w3.org/WAI/ARIA/apg/patterns/accordion/ — Home, End
  2. https://www.w3.org/WAI/ARIA/apg/patterns/carousel/examples/carousel-2-tablist/ — Home, End
  3. https://www.w3.org/WAI/ARIA/apg/patterns/combobox/ — Home, End
  4. https://www.w3.org/WAI/ARIA/apg/patterns/feed/ — CTRL+Home, CTRL+End, PageUp, PageDown
  5. https://www.w3.org/WAI/ARIA/apg/patterns/grid/ — Home, End, CTRL+Home, CTRL+End, PageUp, PageDown
  6. https://www.w3.org/WAI/ARIA/apg/patterns/listbox/ — CTRL+Home, CTRL+End, CTRL+SHIFT+Home, CTRL+SHIFT+End
  7. https://www.w3.org/WAI/ARIA/apg/patterns/menubar/ — Home, End
  8. https://www.w3.org/WAI/ARIA/apg/patterns/slider-multithumb/examples/slider-multithumb/ — Home, End, PageUp, PageDown
  9. https://www.w3.org/WAI/ARIA/apg/patterns/slider/ — Home, End, PageUp, PageDown
  10. https://www.w3.org/WAI/ARIA/apg/patterns/spinbutton/ — Home, End, PageUp, PageDown
  11. https://www.w3.org/WAI/ARIA/apg/patterns/tabs/ — Home, End
  12. https://www.w3.org/WAI/ARIA/apg/patterns/toolbar/ — Home, End
  13. https://www.w3.org/WAI/ARIA/apg/patterns/treegrid/ — Home, End, CTRL+Home, CTRL+End, PageUp, PageDown
  14. https://www.w3.org/WAI/ARIA/apg/patterns/treeview/ — Home, End, CTRL+SHIFT+Home, CTRL+SHIFT+End
  15. https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/ — Home, End

@mcking65
Copy link
Contributor Author

@mendeza asks:

Do you have a strong rationale for using modifiers in the Feed Example, or would you advise leeway and not object to unmodified use? Many thanks for your guidance.

The recommendations for keyboard commands intend to reflect similar conventions. Typically, unmodified home/end stay within a narrowly scoped context where as when modified by control, they make a larger change within the context. For example:

  • home in a grid moves to start of current row while ctrl+home moves to start of first row
  • Home in a text field or doc moves to start of current line while ctrl+home moves to start of first line

In the context of feed, ctrl+home and ctrl+end are more akin to moving to top of doc and bottom of doc than start of line and end of line. That leaves options for home and end to be used within a smaller context, e.g., start of article and end of article, which are commands we did not define. As a new pattern with no precedent in native Windows, macOS, or Linux, the feed pattern is still somewhat a solution in incubation. That is part of the rationale for keeping this issue open for feedback and questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern Page Related to a page documenting a Pattern
Projects
None yet
Development

No branches or pull requests

5 participants