Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar Example: Use button elements and add other types of elements, such as link and checkbox #541

Closed
3 tasks done
mcking65 opened this issue Nov 26, 2017 · 4 comments
Closed
3 tasks done

Toolbar Example: Use button elements and add other types of elements, such as link and checkbox #541

mcking65 opened this issue Nov 26, 2017 · 4 comments
Assignees
@mcking65
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern good first issue Issue with Straightforward resolution; could be good learning experience for new contributors help wanted Task force is looking for an owner for the issue
Milestone
1.1 APG Release 3

Comments

@mcking65
Copy link
Contributor

mcking65 commented Nov 26, 2017 •
edited
Loading

In the toolbar example,
make the following enhancements:

  • replace some of the buttons with other types of elements, such as link, checkbox, toggle button, and switch.
  • For the link and buttons, provide some indication of activation when activated, e.g., popup a window alert.
  • Change <div role="button"> to HTML <button> elements.
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy good first issue Issue with Straightforward resolution; could be good learning experience for new contributors help wanted Task force is looking for an owner for the issue labels Nov 26, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Nov 26, 2017
@mcking65 mcking65 changed the title Toolbar Example: Add other types of elements, such as link and checkbox Toolbar Example: Use button elements and add other types of elements, such as link and checkbox Nov 27, 2017
@mcking65 mcking65 mentioned this issue Nov 27, 2017
Closed
6 tasks
@mcking65 mcking65 self-assigned this Dec 14, 2017
@mcking65
Copy link
Contributor Author

@gerardkcohen is working on this issue.

@hiwelo
Copy link

hiwelo commented Aug 18, 2018

@gerardkcohen are you still working on this issue? If not, I can try to update the component based on the requirements described in this issue 👍 cc @mcking65

@gerardkcohen
Copy link
Contributor

Yes, I still intend in finishing this. It is very close to being done.

@mcking65 mcking65 mentioned this issue Aug 28, 2018
Closed
7 tasks
@jongund jongund mentioned this issue Sep 15, 2018
Merged
@mcking65
Copy link
Contributor Author

mcking65 commented Dec 3, 2018

With commit 599d2de from pr #887, the issue541-toolbar-redesign feature branch now contains all changes needed to resolve this issue. Further review will be managed in issue #539.

@mcking65 mcking65 closed this as completed Dec 3, 2018
mcking65 pushed a commit that referenced this issue Jan 15, 2019
@jongund @mcking65
Toolbar Example: Fix bugs and redesign to add more types of widgets (…
a161bc6 
…#pull 950)

completes work to:

* Resolve keyboard, aria-disabled, and aria-label bugs listed in issue #847.
* Add additional widget types requested in issue #541, including toggle, checkbox, spinner, menu button, radio group, and link.
* The above are all issues discussed in toolbar review issue #539.

Note: missing regression tests are tracked by issue #965.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern good first issue Issue with Straightforward resolution; could be good learning experience for new contributors help wanted Task force is looking for an owner for the issue
Projects
Toolbar Pattern and Examples Development Project
Status: Complete
Milestone
1.1 APG Release 3
Development

No branches or pull requests
3 participants
@gerardkcohen @hiwelo @mcking65