Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Grid and Table Properties guidance section #505

Closed
3 tasks done
mcking65 opened this issue Oct 30, 2017 · 5 comments
Closed
3 tasks done

Review Grid and Table Properties guidance section #505

mcking65 opened this issue Oct 30, 2017 · 5 comments
Assignees
Labels
Practice Page Related to a page within the practices section of the APG

Comments

@mcking65
Copy link
Contributor

mcking65 commented Oct 30, 2017

A draft of the Grid and Table Properties
guidance section is ready for review.

Task Force Member Reviews Requested as of October 29, 2017

@devarshipant
Copy link

Some observations:

Section 6

  1. extra space

determine :

should be:
determine:

  1. Possible Rephrasing

Browsers can automatically calculate dimension information and put it into their accessibility tree based on what is in the DOM.

could be:
Wherever possible, browsers, based on the rendered DOM, automatically calculate dimension information and store it in their accessibility tree.

  1. lower vs. upper case

additionally, some of this information, like skipped columns or rows and how data is sorted, cannot be derived from the DOM structure.

should be:
Additionally ...

Section 6.1

  1. spell check

commyunicate and indicies

should be:
communicate; indices

  1. Item # 3

If cells span multiple rows, set to the index of the first row in the span.

should be:
Set to the index of the first row in the span if cells span multiple rows.

  1. spell check

devastating

should be:
devastating

Section 6.2

  1. spell check

commyunicate and indicies

should be:
communicate; indices

  1. Item # 3

If a cell spans multiple columns, set to the index of the first column in the span.

should be:
Set to the index of the first column in the span if a cell spans multiple columns.

@shirsha
Copy link

shirsha commented Oct 31, 2017

Apart from the spelling mistakes identified above one more semantic error it in 6.2.2 section it should be : have been scrolled to show (instead of sshow) columns 10 t hrough 13.
Remaining looks good for me.

@annabbott
Copy link

All issues have been previously reported.

mcking65 added a commit that referenced this issue Nov 16, 2017
Per feedback in issue #505, modify the grid and table properties section of aria-practices.html to:
1. Correct spelling and spacing errors.
2. Clarify wording.

Also, removed the link to feedback issue 505.
@mcking65
Copy link
Contributor Author

@devarshipant, @shirsha, and @annabbott, Thank you for the excellent attention to detail.

I have pushed commit 40b6c22 with the following changes.

@devarshipant commented:

  1. extra space: "determine :" should be "determine:"

Fixed.

  1. Possible Rephrasing

Browsers can automatically calculate dimension information and put it into their accessibility tree based on what is in the DOM.
could be:
Wherever possible, browsers, based on the rendered DOM, automatically calculate dimension information and store it in their accessibility tree.

I changed to: "Browsers automatically populate their accessibility tree with the number of rows and columns in a grid or table based on the rendered DOM."

  1. lower vs. upper case

additionally, some of this information, like skipped columns or rows and how data is sorted, cannot be derived from the DOM structure.
should be:
Additionally ...

Fixed.

Section 6.1

  1. spell check: "commyunicate" and "indicies" should be: communicate; indices

Fixed.

  1. Item # 3

If cells span multiple rows, set to the index of the first row in the span.
should be:
Set to the index of the first row in the span if cells span multiple rows.

Fixed.

  1. spell check "devistating" should be devastating

Fixed.

Section 6.2

  1. spell check "commyunicate" and "indicies" should be: communicate; indices

Fixed.

  1. Item # 3

If a cell spans multiple columns, set to the index of the first column in the span.
should be:
Set to the index of the first column in the span if a cell spans multiple columns.

Fixed.

@shirsha commented:

Apart from the spelling mistakes identified above one more semantic error it in 6.2.2 section it should be:
have been scrolled to show (instead of sshow)

Fixed.

@mcking65
Copy link
Contributor Author

Thank you all for the help with this, especially @jongund for the initial draft. Closing as complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Practice Page Related to a page within the practices section of the APG
Projects
None yet
Development

No branches or pull requests

5 participants