Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu and Menubar Pattern: missing guidance on labeling menus and menubars #462

Closed
mcking65 opened this issue Sep 21, 2017 · 1 comment
Closed

Menu and Menubar Pattern: missing guidance on labeling menus and menubars #462

mcking65 opened this issue Sep 21, 2017 · 1 comment
Assignees
@mcking65
Labels
Pattern Page Related to a page documenting a Pattern
Milestone
1.1 APG Release 1

Comments

@mcking65
Copy link
Contributor

The menu and menubar pattern
does not include any labeling guidance in the roles, states, and properties.
@mcking65 mcking65 added documentation Pattern Page Related to a page documenting a Pattern labels Sep 21, 2017
@mcking65 mcking65 added this to the 1.1 Rec milestone Sep 21, 2017
@mcking65 mcking65 modified the milestones: 1.1 Rec, 3Q17 Working Draft Oct 10, 2017
@mcking65 mcking65 self-assigned this Oct 10, 2017
mcking65 added a commit that referenced this issue Nov 6, 2017
@mcking65
Menu and Menubar Pattern: Add Labeling Guidance
a7035a7 
To resolve issue #462, Added the following bullets to
roles, states, and properties subsection of the menu and menubar pattern in aria-practices.html.

> * If a menubar has a visible label, the element with role menubar has aria-labelledby set to a value that refers to the labeling element. Otherwise, the menubar element has a label provided by aria-label.
> * An element with role menu either has:
>    * aria-labelledby set to a value that refers to the menuitem or button that controls its display.
>    * A label provided by aria-label.
@mcking65
Copy link
Contributor Author

mcking65 commented Nov 6, 2017

Resolved with commit a7035a7. The pattern is now consistent with examples.

@mcking65 mcking65 closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
Pattern Page Related to a page documenting a Pattern
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
1 participant
@mcking65