Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAQ Disclosure Example: space does not toggle visibility #311

Closed
mcking65 opened this issue Mar 11, 2017 · 1 comment
Closed

FAQ Disclosure Example: space does not toggle visibility #311

mcking65 opened this issue Mar 11, 2017 · 1 comment
Assignees
@jongund
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone
Jan 2017 Clean Up

Comments

@mcking65
Copy link
Contributor

Per feedback in issue #265 from @annabbott, when using Firefox on the
FAQ disclosure example,
the space key does not open and close the disclosure like it should.
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Mar 11, 2017
@mcking65 mcking65 added this to the Jan 2017 Clean Up milestone Mar 11, 2017
mcking65 pushed a commit that referenced this issue Mar 12, 2017
@jongund @mcking65
Disclosure Examples: Fix Space Bar Bug
db44c5a 
For issue #311:
1. Update js so space bar now toggles the expanded/collapsed state of the disclosure.
2. Update documentation.
@mcking65
Copy link
Contributor Author

This issue is now fixed with commit in pull request #312. Thank you @jongund!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongund jongund

Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
Command, Toggle, Menu, and Disclosure Button Patterns and Examples Development Project
Status: Complete
Milestone
Jan 2017 Clean Up
Development

No branches or pull requests
2 participants
@jongund @mcking65