-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example page design #292
Comments
Instead of creating something complete new, why don’t we include the base.css that is used on all specs? I’ve tried this on my local machine and it works pretty well, it’ll need some customisations here and there to fit our content, but other than that, it could save a lot of time while also making the example pages’s design more in line with the spec itself. |
I’ve created an example of what I stated in my previous comment: Tabs example page with new design Changes:
Please let me know what you think. |
Michiel, It's Definitely important to do what we can to make the content easy to read and visually consistent. So, thank you, thank you for raising the issue and working on a proposal! Borrowing from the spec styles seems like a good idea. And, the style changes you list "sound" great :). I too would like to have breadcrumbs, but I would like to add them separately and later. Because the guide will balloon in size and get much more difficult to navigate by the time we cover everything in scope, after our next heartbeat publication, I am planning to introduce a concept proposal for a new information architecture and structure to make it easier to use. One aspect of the concept is dividing the guide into a few major sections that each have their own page. If we go that route, it would effect the breadcrumb links. So, to avoid potential rework, I'd like to hold off on adding breadcrumbs to example pages. When we do implement breadcrumbs, however, the nav element should be before main, not inside main, and it may be inside of a banner that also includes a W3C logo like on the main doc. |
Matt, That sounds good to me. Since all changes aside from the breadcrumbs are CSS related this can be implemented fairly easily. If there are no further objections I’ll implement this (excluding breadcrumbs) over the weekend. Update: All example pages have been updated in the design branch. I’ll double check them after I’ve had some sleep. Will merge after that. |
This is now done. |
@MichielBijl class="hljs-attr" on the #f8f8f8 background only has a 4.49:1 ratio according to aXe. Can we tweak this so that it definitively passes. I don't think we should have anything which is borderline |
Will do!
|
The pages can use a more inviting look. The current design is bit dull, dark, and too compact.
Some ideas:
<kbd>
that stands outFeel free to give feedback in this issue.
This issue is related to issue #168.
The text was updated successfully, but these errors were encountered: