-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples.js: Source code syntax highlighter bug creates color problem in HTML source display for date picker combobox example #2815
Comments
Same happens for the Example Disclosure Navigation Menu with Top-Level Links example: https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/examples/disclosure-navigation-hybrid/ |
It shows as light green color because span class |
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: Issue 2815 - Color contrast problem in source code section of example pages<jugglinmike> github: https://github.com//issues/2815 <jugglinmike> Matt_King: This has screen shots describing the color contrast in the source code <jugglinmike> Jem: the reporter is saying that the use of green/red will be a problem for some folks <jugglinmike> Matt_King: Does this pass WCAG? <jugglinmike> Jem: I can check if the contrast is technically an accessibility issue <jugglinmike> Jem: Regardless of contrast and colors, though, it just doesn't look consistent <jugglinmike> Matt_King: Based soley on what's written, it sounds like a contrast issue--not a green-red color issue <jugglinmike> jugglinmike: the syntax hilighter is malfunctioning. It's highlighting the code in a way that doesn't make logical sense <jugglinmike> [the group investigates the syntax highlighting behavior] <jugglinmike> Jem: I'll leave a comment with some additional information about the problem <jugglinmike> Matt_King: I'll modify the title so the problem is a little more clear <jugglinmike> Matt_King: This doesn't effect every example page, right? Just some of them. <jugglinmike> Jem: That's right <jugglinmike> Matt_King: Okay, I think we have good documentation, now, and we have a path forward |
Resolved by #2939. @giacomo-petri, thank you for raising this issue. The fix will go live in production on April 9. |
In Date Picker Combobox Example the HTML source code is not properly formatted, causing a color contrast issue for green text over light grey background, as per attachment.
The text was updated successfully, but these errors were encountered: