Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate/embed Feed example into APG Pattern Page #2747

Closed
a11ydoer opened this issue Jul 11, 2023 · 2 comments · Fixed by #2775
Closed

Incorporate/embed Feed example into APG Pattern Page #2747

a11ydoer opened this issue Jul 11, 2023 · 2 comments · Fixed by #2775
Assignees
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern

Comments

@a11ydoer
Copy link
Contributor

Feed example is currently located at a separate page. It would be great if we can embed the Feed example inside of APG Feed pattern page.

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Incorporate/embed Feed example into APG Pattern Page · Issue #2747 · w3c/aria-practices.

The full IRC log of that discussion <jugglinmike> subtopic: Incorporate/embed Feed example into APG Pattern Page · Issue #2747 · w3c/aria-practices
<jugglinmike> github: https://github.com//issues/2747
<jugglinmike> Matt_King: This is about the feed example which is anomalous because we have the "feed" page and a separate page called "feed display"
<jugglinmike> Matt_King: We originally thought that putting the feed in the middle of the example page would have been a problem, and not very realistic besides
<jugglinmike> Matt_King: We thought we'd be able to make a more realistic example if we put it on its own page
<jugglinmike> Matt_King: With the new site design, I'm not sure if that's still true
<jugglinmike> Matt_King: We may now be able to embed the feed directly into the example page and get rid of the "feed display" page
<jugglinmike> Matt_King: It seems like a fairly straightforward exercise to do this
<jugglinmike> arigilmore: I can give it a try
<jugglinmike> Jem: The page says that the feed does not yet have ARIA-Practices task force consensus. Is that still true?
<jugglinmike> Matt_King: We might want to change the wording there
<jugglinmike> Matt_King: The parts of this that are kind of unusual are that because this does not have a native equivalent, we don't have patterns to go off of for keyboard commands (in particular for nested feeds)
<jugglinmike> Matt_King: For instance, to exit a feed, we use "Control + End", but we could do a lot of different things
<jugglinmike> Matt_King: This example is also distinct in that it generates new HTML content dynamically, and in that it simulates timing
<jugglinmike> Jem: I can help you if there are any problems with the template, arigilmore, because I need to better understand how templates work
<jugglinmike> arigilmore: Thanks! I'll let you know
<jugglinmike> Matt_King: I've assigned the issue to arigilmore

@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern labels Jul 25, 2023
@mcking65 mcking65 added this to the H2/2023 Content Updates milestone Jul 25, 2023
@mcking65
Copy link
Contributor

@ariellalgilmore

As a member of the GitHub ARIA Contributors team, you can create a branch in the aria-practices repo rather than work off of a fork like you did in #2723. Using a branch in this repo makes it easier to collaborate and keep the branch current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
5 participants