Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression test menu-button_links.js "enter" on role="menuitem" sometimes fails in CI #1937

Open
zcorpan opened this issue Jun 7, 2021 · 1 comment
Open

Regression test menu-button_links.js "enter" on role="menuitem" sometimes fails in CI #1937

zcorpan opened this issue Jun 7, 2021 · 1 comment
Labels
regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo

Comments

@zcorpan
Copy link
Member

zcorpan commented Jun 7, 2021

See

#1888
#1923 (comment)

I had hoped that PR #1921 would fix the test, and that PR was passing in CI. Yet the above PRs, when rebased, still failed the same test. Locally the test is passing for me. I've looked at it again today but I don't know why it's failing.

I suggest we comment out this test for now, so that it's not blocking progress on other PRs. We can keep this issue open to track fixing and re-enabling the test.
@zcorpan zcorpan added the regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo label Jun 7, 2021
@zcorpan zcorpan self-assigned this Jun 7, 2021
zcorpan added a commit that referenced this issue Jun 7, 2021
@zcorpan
Comment out a test in menu-button_links.js
eec390a 
See #1937
This was referenced Jun 7, 2021
Merged
Merged
jesdaigle pushed a commit that referenced this issue Nov 2, 2021
@zcorpan
Comment out a test in menu-button_links.js (#1938)
19f4482 
See #1937
@zcorpan zcorpan removed their assignment Nov 29, 2021
@zcorpan
Copy link
Member Author

zcorpan commented Nov 29, 2021

#1938 was merged, but keeping this open per OP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zcorpan