Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menubar Examples: Remove (or replace) all remaining instances of "menubar-1" and "menubar-2" #1457

Closed
carmacleod opened this issue Jul 20, 2020 · 0 comments · Fixed by #1490
Closed

Menubar Examples: Remove (or replace) all remaining instances of "menubar-1" and "menubar-2" #1457

carmacleod opened this issue Jul 20, 2020 · 0 comments · Fixed by #1490
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Milestone
1.2 Release 1

Comments

@carmacleod
Copy link
Contributor

With @jongund's recent refactoring and renaming of the menubar examples in #1359, any reference to "menubar-1" and "menubar-2" can now be removed (or in some cases, updated to use the new name).

This includes:

  • Delete the menubar-2 folder and all of its contents
  • Delete or update all mentions of menubar-2 in coverage/index.html and examples/index.html
  • Delete test/tests/menubar_menubar-2.js... but only after comparing with test/tests/menubar_menubar-editor.js because there are some typo fixes and possibly other fixes that need to be moved to the new file
  • Update instances of menubar-1 in test/util/report_files/ignore_html_files
@carmacleod carmacleod mentioned this issue Aug 10, 2020
Merged
@carmacleod carmacleod linked a pull request Aug 21, 2020 that will close this issue
Menubar Examples: Remove outdated files #1490
Merged
@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern labels Aug 24, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Aug 24, 2020
@mcking65 mcking65 changed the title Remove (or replace) all remaining instances of "menubar-1" and "menubar-2" Menubar Examples: Remove (or replace) all remaining instances of "menubar-1" and "menubar-2" Aug 24, 2020
mcking65 added a commit that referenced this issue Aug 24, 2020
@mcking65
Menubar Examples: Remove unused files (pull #1490)
51cf5d7 
Resolves #1457 with following changes:
* Remove old menubar-2 directory
* Update examples index
* Update coverage reports
* Delete menubar-2 test file
* Remove reference to deleted files

Co-authored-by: Valerie Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
1.2 Release 1
Development

Successfully merging a pull request may close this issue.

Menubar Examples: Remove outdated files w3c/aria-practices
2 participants
@carmacleod @mcking65