Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigation menubar example: Improve high contrast support and refactor Javascript #1357

Closed
jongund opened this issue Mar 19, 2020 · 0 comments · Fixed by #1359
Closed

navigation menubar example: Improve high contrast support and refactor Javascript #1357

jongund opened this issue Mar 19, 2020 · 0 comments · Fixed by #1359
Assignees
@jongund
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Milestone
1.2 Release 1

Comments

@jongund
Copy link
Contributor

jongund commented Mar 19, 2020

Update the navigation menubar Javascript to:

  1. Javascript uses a single object
  2. Improve support for high contrast mode
@jongund jongund mentioned this issue Mar 26, 2020
Merged
5 tasks
@mcking65 mcking65 changed the title Update navigation menubar example Javascript navigation menubar example: Improve high contrast support and refactor Javascript Apr 21, 2020
@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern labels Apr 21, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Apr 21, 2020
mcking65 added a commit that referenced this issue Jul 19, 2020
@jongund @mcking65
Navigation Menubar Example: Improve high contrast support and refacto…
eddfdee 
…r javascript (pull #1359)

closes issue #1357 by making the following changes:
* Updated javascript to use a single object.
* Updated CSS and JS to improve high contrast support.

Co-authored-by: Matt King <[email protected]>
michael-n-cooper pushed a commit that referenced this issue Jul 19, 2020
@mcking65
Generated by TRAVIS-CI eddfdee
b4f0c58 
Navigation Menubar Example: Improve high contrast support and refactor javascript (pull #1359)

closes issue #1357 by making the following changes:
* Updated javascript to use a single object.
* Updated CSS and JS to improve high contrast support.

Co-authored-by: Matt King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongund jongund

Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
1.2 Release 1
Development

Successfully merging a pull request may close this issue.

Navigation Menubar Example: Improve high contrast support and refactor javascript w3c/aria-practices
2 participants
@jongund @mcking65