Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeling and describing: missing type="radio" in example #1060

Closed
zcorpan opened this issue Jun 28, 2019 · 4 comments
Closed

Labeling and describing: missing type="radio" in example #1060

zcorpan opened this issue Jun 28, 2019 · 4 comments
Assignees
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.

Comments

@zcorpan
Copy link
Member

zcorpan commented Jun 28, 2019

  <fieldset>
    <legend>Select your starter class</legend>
    <label><input name="starter-class" value="green"> Green</label>
    <label><input name="starter-class" value="red"> Red</label>
    <label><input name="starter-class" value="blue"> Blue</label>
  </fieldset>

These are intended to be type="radio". cc @spectranaut

@zcorpan
Copy link
Member Author

zcorpan commented Jun 28, 2019

also in this example

<fieldset title="Select your starter class">
    <label><input name="starter-class" value="green"> Green</label>
    <label><input name="starter-class" value="red"> Red</label>
    <label><input name="starter-class" value="blue"> Blue</label>
   </fieldset>

(which also has indentation slightly off)

@zcorpan
Copy link
Member Author

zcorpan commented Jun 28, 2019

More typos in examples

 <tr><th>Week<th>Monday<th>Tuesday<th>Wednesday<th>Thursday<th>Friday<Saturday<Sunday

<Saturday<Sunday should be <th>Saturday<th>Sunday

@mcking65 mcking65 added documentation editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. labels Jul 2, 2019
@mcking65 mcking65 added this to the 1.1 APG Release 4 milestone Jul 2, 2019
@mcking65
Copy link
Contributor

mcking65 commented Jul 2, 2019

@spectranaut, could you make these changes in a commit to the issue1050-naming-describing-feedback branch? That branch will be merged with #1062 in the next version of the naming and describing section.

@spectranaut
Copy link
Contributor

sure thing, done!

mcking65 added a commit that referenced this issue Jul 11, 2019
… 1050 (pull #1062)

* Fallback naming guidance section: reference cardinal rule 4 to avoid it.
* Naming Rule 3: Remove mention of alt attribute: Per feedback from @LJWatson in issue #1050, revises rule 3 to remove mention of alt.
* Adds sentence refering readers to the naming techniques for specific advantages of using HTML features instead of ARIA.
* Fix formatting and bugs in code snippets reported in #1060.
* Intro: most fundamental and important -> most important
* Minor editorial change to section: How Are Name and Description Strings Derived?
* Intro paragraph: additional editorial simplification based on feedback from @LJWatson in issue #1050.
* Clarify language describing when captions become descriptions: to resolve feedback from @jessebeach in issue #1050. Modified language in sections 5.3.2.6 Naming Tables and Figures with Captions  and  section 5.4.1.3 Describing Tables and Figures with Captions.
* Provide richer description of screen reader behavior in section 5.1 per feedback from @jongund in issue #1050.
* Remove aria-details guidance, which will be addressed in the future by issue #70.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Projects
None yet
Development

No branches or pull requests

3 participants