Skip to content

Commit

Permalink
Remove aria-haspopup from examples where it is not necessary
Browse files Browse the repository at this point in the history
  • Loading branch information
mcking65 committed Nov 14, 2019
1 parent dd6f6c0 commit e51ad04
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 27 deletions.
10 changes: 1 addition & 9 deletions examples/combobox/combobox-autocomplete-both.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ <h2 id="ex_label">Example</h2>
<label for="cb1-input">State</label>
<div class="group">
<input id="cb1-input" class="cb_edit" type="text" role="combobox" aria-autocomplete="both"
aria-expanded="false" aria-haspopup="true" aria-controls="lb1"
aria-expanded="false" aria-controls="lb1"
/>
<button type="button" id="cb1-button" aria-label="Open" tabindex="-1">&#9661;</button>
</div>
Expand Down Expand Up @@ -304,14 +304,6 @@ <h3 id="rps_label_textbox">Textbox</h3>
<td><code>input[type="text"]</code></td>
<td>Indicates that the autocomplete behavior of the text input is to both show an inline completion string and suggest a list of possible values in a popup where the suggestions are related to the string that is present in the textbox.</td>
</tr>
<tr data-test-id="combobox-aria-haspopup">
<td></td>
<th scope="row">
<code>aria-haspopup="true"</code>
</th>
<td><code>input[type="text"]</code></td>
<td>Indicates that the combobox can popup another element to suggest values.</td>
</tr>
<tr data-test-id="combobox-aria-controls">
<td></td>
<th scope="row">
Expand Down
10 changes: 1 addition & 9 deletions examples/combobox/combobox-autocomplete-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ <h2 id="ex_label">Example</h2>
<label for="cb1-input">State</label>
<div class="group">
<input id="cb1-input" class="cb_edit" type="text" role="combobox" aria-autocomplete="list"
aria-expanded="false" aria-haspopup="true" aria-controls="cb1-listbox"
aria-expanded="false" aria-controls="cb1-listbox"
/>
<button id="cb1-button" tabindex="-1" aria-label="Open">&#9661;</button>
</div>
Expand Down Expand Up @@ -299,14 +299,6 @@ <h3 id="rps_label_textbox">Textbox</h3>
<td><code>input[type="text"]</code></td>
<td>Indicates that the autocomplete behavior of the text input is to suggest a list of possible values in a popup and that the suggestions are related to the string that is present in the textbox.</td>
</tr>
<tr data-test-id="combobox-aria-haspopup">
<td></td>
<th scope="row">
<code>aria-haspopup="true"</code>
</th>
<td><code>input[type="text"]</code></td>
<td>Indicates that the combobox can popup another element to suggest values.</td>
</tr>
<tr data-test-id="combobox-aria-controls">
<td></td>
<th scope="row">
Expand Down
9 changes: 0 additions & 9 deletions examples/combobox/combobox-autocomplete-none.html
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ <h2 id="ex_label">Example</h2>
role="combobox"
aria-autocomplete="none"
aria-expanded="false"
aria-haspopup="true"
aria-controls="cb1-listbox"
/>
<button type="button" id="cb1-button" tabindex="-1" aria-label="Open">
Expand Down Expand Up @@ -252,14 +251,6 @@ <h3 id="rps_label_textbox">Textbox</h3>
<td><code>input[type="text"]</code></td>
<td>Indicates that the suggestions in the combobox popup are not values that complete the current textbox input.</td>
</tr>
<tr data-test-id="combobox-aria-haspopup">
<td></td>
<th scope="row">
<code>aria-haspopup="true"</code>
</th>
<td><code>input[type="text"]</code></td>
<td>Indicates that the combobox can popup another element to suggest values.</td>
</tr>
<tr data-test-id="combobox-aria-controls">
<td></td>
<th scope="row">
Expand Down

0 comments on commit e51ad04

Please sign in to comment.