Infrastructure: Enable ESLint no-console (pull #1646)

w3c · Dec 14, 2020 · 601cebd · 601cebd
1 parent b874a47
commit 601cebd
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 9 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -8,7 +8,8 @@
     "ecmaVersion": 6
   },
   "rules": {
-    "strict": [2, "global"]
+    "strict": [2, "global"],
+    "no-console": "error"
   },
   "overrides": [
     {

diff --git a/examples/checkbox/checkbox-2/js/controlledCheckbox.js b/examples/checkbox/checkbox-2/js/controlledCheckbox.js
@@ -24,8 +24,6 @@ var ControlledCheckbox = function (domNode, controllerObj) {
 ControlledCheckbox.prototype.init = function () {
   this.lastState = this.isChecked();
 
-  console.log(this.lastState);
-
   this.domNode.addEventListener('change', this.handleChange.bind(this));
 
   this.domNode.addEventListener('keydown', this.handleKeyup.bind(this), true);

diff --git a/examples/disclosure/js/disclosureButton.js b/examples/disclosure/js/disclosureButton.js
@@ -66,8 +66,6 @@ ButtonExpand.prototype.toggleExpand = function () {
 /* EVENT HANDLERS */
 
 ButtonExpand.prototype.handleKeydown = function (event) {
-  console.log('[keydown]');
-
   switch (event.keyCode) {
     case this.keyCode.RETURN:
       this.toggleExpand();

diff --git a/examples/js/examples.js b/examples/js/examples.js
@@ -435,13 +435,15 @@ function addOpenInCodePenForm(
         }
         totalFetchedFiles++;
       } else {
+        // eslint-disable-next-line no-console
         console.warn(
           "Not showing 'Open in Codepen' button. Could not load resource: " +
             href
         );
       }
     };
     request.onerror = function () {
+      // eslint-disable-next-line no-console
       console.warn(
         "Not showing 'Open in Codepen' button. Could not load resource: " +
           fileLink.href
@@ -461,6 +463,7 @@ function addOpenInCodePenForm(
 
   setTimeout(() => {
     clearInterval(timerId);
+    // eslint-disable-next-line no-console
     console.warn(
       "Not showing 'Open in Codepen' button. Timeout when loading resource."
     );

diff --git a/examples/slider/js/vertical-slider.js b/examples/slider/js/vertical-slider.js
@@ -105,7 +105,6 @@ VSlider.prototype.moveVSliderTo = function (value) {
   if (this.valueDomNode) {
     this.valueDomNode.innerHTML = this.valueNow.toString();
     this.valueDomNode.style.left = this.railDomNode.offsetWidth / 2 - 2 + 'px';
-    console.log(this.valueDomNode.style.left);
   }
 };
 

diff --git a/test/tests/combobox_autocomplete-both.js b/test/tests/combobox_autocomplete-both.js
@@ -169,7 +169,6 @@ ariaTest(
     );
     const id = await combobox.getAttribute('id');
 
-    console.log(id);
     t.truthy(id, '"id" attribute should exist on combobox');
 
     const label = await t.context.queryElements(t, `[for="${id}"]`);

diff --git a/test/tests/combobox_autocomplete-list.js b/test/tests/combobox_autocomplete-list.js
@@ -168,7 +168,6 @@ ariaTest(
     );
     const id = await combobox.getAttribute('id');
 
-    console.log(id);
     t.truthy(id, '"id" attribute should exist on combobox');
 
     const label = await t.context.queryElements(t, `[for="${id}"]`);

diff --git a/test/tests/combobox_autocomplete-none.js b/test/tests/combobox_autocomplete-none.js
@@ -177,7 +177,6 @@ ariaTest(
     );
     const id = await combobox.getAttribute('id');
 
-    console.log(id);
     t.truthy(id, '"id" attribute should exist on combobox');
 
     const label = await t.context.queryElements(t, `[for="${id}"]`);

diff --git a/test/util/report.js b/test/util/report.js
@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+/* eslint-disable no-console */
 
 const cheerio = require('cheerio');
 const path = require('path');