Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force ATDriverGenericMacOSExtensionAudioUnit channel capabilities to no input, mono output #47

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

stalgiag
Copy link
Contributor

@stalgiag stalgiag commented Apr 3, 2024

This was required to complete installation on my system.

It seems that if the system has a broader set of output capabilities, this can invalidate theAudioUnit due to a mismatch between its announced capabilities and the host's expectations.

Prior to this change, the auval -v ausp atdg BOCU portion of theat-driver install script produced this error on both my system and @boazsender 's.

Error: Command failed: auval -v ausp atdg BOCU

    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:517:28)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:303:5) {
  code: 255,
  killed: false,
  signal: null,
  cmd: 'auval -v ausp atdg BOCU',
  stdout: '\n' +
    '    AU Validation Tool\n' +
    '    Version: 1.10.0 \n' +
    '    Copyright 2003-2019, Apple Inc. All Rights Reserved.\n' +
    '    Specify -h (-help) for command options\n' +
    '\n' +
    '--------------------------------------------------\n' +
    "VALIDATING AUDIO UNIT: 'ausp' - 'atdg' - 'BOCU'\n" +
    '--------------------------------------------------\n' +
    'Manufacturer String: Bocoup LLC\n' +
    'AudioUnit Name: ATDriverGenericMacOSExtension\n' +
    'Component Version: 1.6.0 (0x10600)\n' +
    '\n' +
    '* * PASS\n' +
    '--------------------------------------------------\n' +
    'TESTING OPEN TIMES:\n' +
    'COLD:\n' +
    '\n' +
    'Loaded AudioUnit out-of-process: true \n' +
    'Time to open AudioUnit:         107.285 ms\n' +
    'WARM:\n' +
    '\n' +
    'Loaded AudioUnit out-of-process: true \n' +
    'Time to open AudioUnit:         105.172  ms\n' +
    'This AudioUnit is a version 3 implementation.\n' +
    'FIRST TIME:\n' +
    'Time for initialization:        31.114 ms\n' +
    '\n' +
    '* * PASS\n' +
    '--------------------------------------------------\n' +
    'VERIFYING DEFAULT SCOPE FORMATS:\n' +
    'Input Scope Bus Configuration:\n' +
    ' Default Bus Count:0\n' +
    '\n' +
    'Output Scope Bus Configuration:\n' +
    ' Default Bus Count:1\n' +
    '    Default Format: AudioStreamBasicDescription:  1 ch,  22050 Hz, Float32\n' +
    '\n' +
    '* * PASS\n' +
    '--------------------------------------------------\n' +
    'VERIFYING REQUIRED PROPERTIES:\n' +
    '\n' +
    '* * PASS\n' +
    '--------------------------------------------------\n' +
    'VERIFYING RECOMMENDED PROPERTIES:\n' +
    '\n' +
    '* * PASS\n' +
    '--------------------------------------------------\n' +
    'VERIFYING OPTIONAL PROPERTIES:\n' +
    '  VERIFYING PROPERTY: Latency\n' +
    '    PASS\n' +
    '  VERIFYING PROPERTY: Tail Time\n' +
    '    PASS\n' +
    '  VERIFYING PROPERTY: Bypass Effect\n' +
    '    PASS\n' +
    '\n' +
    '* * PASS\n' +
    '--------------------------------------------------\n' +
    'VERIFYING SPECIAL PROPERTIES:\n' +
    '\n' +
    'VERIFYING CUSTOM UI\n' +
    'Cocoa Views Available: 0\n' +
    'WARNING: CurrentPreset property is deprectated. AU should implement PresentPreset\n' +
    '\n' +
    'VERIFYING CLASS INFO\n' +
    '    PASS\n' +
    '\n' +
    'TESTING HOST CALLBACKS\n' +
    '    PASS\n' +
    '\n' +
    '* * PASS\n' +
    '--------------------------------------------------\n' +
    'PUBLISHED PARAMETER INFO:\n' +
    '\n' +
    '# # # 1 Global Scope Parameters:\n' +
    '\n' +
    '# # Parameters for clump: 212950\n' +
    '# Full Clump Name: Global\n' +
    '# Short (4 Chars limit) Clump Name: Global\n' +
    'Parameter ID:1703748195\n' +
    'Name: Output Gain\n' +
    'Parameter Type: Linear Gain\n' +
    'Values: Minimum = 0.000000, Default = 0.250000, Maximum = 1.000000\n' +
    'Flags: Readable, Writable \n' +
    '  -parameter PASS\n' +
    '\n' +
    'Testing that parameters retain value across reset and initialization\n' +
    '  PASS\n' +
    '\n' +
    '* * PASS\n' +
    '--------------------------------------------------\n' +
    'FORMAT TESTS:\n' +
    '\n' +
    'Reported Channel Capabilities\n' +
    '\n' +
    'No Input, Output Chans:\n' +
    '0-1   0-2   0-4   0-5   0-6   0-7   0-8\n' +
    'X                                         \n' +
    'WARNING: Can Initialize Unit to un-supported num channels:InputChan:0, OutputChan:2\n' +
    'WARNING: Can Initialize Unit to un-supported num channels:InputChan:0, OutputChan:4\n' +
    'WARNING: Can Initialize Unit to un-supported num channels:InputChan:0, OutputChan:5\n' +
    'WARNING: Can Initialize Unit to un-supported num channels:InputChan:0, OutputChan:6\n' +
    'WARNING: Can Initialize Unit to un-supported num channels:InputChan:0, OutputChan:7\n' +
    'WARNING: Can Initialize Unit to un-supported num channels:InputChan:0, OutputChan:8\n' +
    'ERROR: Unit Needs to describe its channel handling capabilities (at least for default config: in:0, out:1)\n' +
    '\n' +
    '* * FAIL\n' +
    '--------------------------------------------------\n' +
    'RENDER TESTS:\n' +
    'ERROR:   Format errors. Cannot perform render tests\n' +
    '\n' +
    '\n' +
    '* * FAIL\n' +
    '--------------------------------------------------\n' +
    'AU VALIDATION FAILED: CORRECT THE ERRORS ABOVE.\n' +
    '--------------------------------------------------\n',
  stderr: ''

@stalgiag stalgiag requested a review from jugglinmike April 3, 2024 16:24
@stalgiag stalgiag changed the title Force channel capabilities to no input, mono output Force ATDriverGenericMacOSExtensionAudioUnit channel capabilities to no input, mono output Apr 3, 2024
Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, @stalgiag! I can't replicate the issue on my system, so my review is limited to verifying that this doesn't regress support.

@jugglinmike jugglinmike merged commit 4732265 into main Jun 24, 2024
6 checks passed
@jugglinmike jugglinmike deleted the specific-channel-capababilities branch June 24, 2024 22:57
jugglinmike pushed a commit to bocoup/at-driver-servers that referenced this pull request Jun 24, 2024
This commit has been cherry-picked from the "aria-at-automation-driver"
project, where it was previously reviewed and approved [1].

[1] w3c/aria-at-automation-driver#47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants