Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit at-driver with error if run as admin #4

Closed
wants to merge 1 commit into from

Conversation

mzgoddard
Copy link
Contributor

When at-driver is run with admin privilege, clients of the named pipe will need the same privilege. It is easy to overlook this when starting at-driver and then using for example a screen reader that is not run with admin privilege. When the automation voice is loaded by said screen reader if it doesn't have equal or better privilege it will not be able to connect to the named pipe. At this time the voice cannot notify the user of this issue and appears to silently fail.

@jugglinmike
Copy link
Contributor

This looks okay to me, but I think we'd both prefer a solution that doesn't involve constraining the end-user. At first, I thought there might be some way for the process to drop permissions, but I've since found a relatively new API that does the job.

I've opened gh-6 as an alternative to this patch.

@mzgoddard mzgoddard closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants