Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macos CI build and test #33

Closed
wants to merge 7 commits into from
Closed

Add macos CI build and test #33

wants to merge 7 commits into from

Conversation

mzgoddard
Copy link
Contributor

No description provided.

ATDriverGenericService is an XPC Service that the Audio Unit extension
messages to forward messages to the lib/cli.js server. This step is used
to keep the AudioUnit speedy.

- Add unix socket path to cli.js
- Create directory for socket and unlink old leftover sockets in cli.js
- Add ATDriverGenericService to xcode project
- Add service dependency to Extension
runs-on: macos-13
steps:
- uses: actions/checkout@v4
- run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind documenting these steps with names?

Comment on lines +16 to +21
say hello
say hello
say hello
say hello
say hello
log show --process ATDriverGenericService | tail -n 10
Copy link
Contributor

@jugglinmike jugglinmike Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect to see five occurrences of the string "hello" in the service logs, but the latest build only reported an error, "no such file or directory".

If the log really is supposed to prove that the speech was captured, then we can make the results easier to interpret with without much more effort by choosing different strings: using five distinct strings will make sequence errors apparent and make it easier to detect when messages are dropped/duplicated. For instance

say hello one of five
say hello two of five
say hello three of five
say hello four of five
say hello five of five

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This combination of say hello and log show here is to try and get any output to indicate the extension and service working.

I first tried it with one say hello. log didn't show anything.

I think the system picking up the configuration change isn't instant. It may be polling based or something?

Either way I think a next step is to use cli to listen for speech from the application extension, and repeat say hello until output shows up. I suspect there isn't a fixed number of say hello we would need to see it show up. In a way I got lucky that 5 worked, but maybe it sometimes need 10, and sometimes 1 may be enough.

@mzgoddard
Copy link
Contributor Author

I'm going to close this PR @jugglinmike. I think it demonstrated what I was hoping for and that next steps on it would be better done in a later PR once some others merge. Thanks for reviewing it!

@mzgoddard mzgoddard closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants