Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallowing Test Plans with Incomplete Tests #512

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from
Draft

Disallowing Test Plans with Incomplete Tests #512

wants to merge 56 commits into from

Conversation

aleenaloves
Copy link
Contributor

Reference Issue: #493

Per the working group, incomplete test plans cannot transition to the candidacy status. This PR is a fix for this issue.

I have ran all these test cases, but have also listed them here for people to double check and/or list if i missed anything.

Test Cases:

  • Verify the test cases from the original issue no longer encounter the error
  • Verify the behavior for an incomplete candidate test already existing
  1. From another branch, transition an incomplete test plan to the candidate status
  2. Migrate back to this branch, verify that the test navigator shows the correct icons for incomplete tests, the incomplete test also shows incomplete, and that a user cannot 'finish' this test.
  • Verify the behavior for an incomplete test plan in review on the test queue page
  1. Create an incomplete test plan
  2. Set it's status to 'In Review'
  3. Validate that you cannot transition it to 'candidate' and that it tells you why you cannot as well.
  • Verify the styling in general
  • Verify that nothing else is broken
  1. General Test Queue Behavior
  2. General Candidate Test Behavior

howard-e and others added 30 commits February 9, 2023 16:12
@howard-e
Update some major dependencies, webpack config and proxy management f…
d83957b 
…or "Open Test Page button"
@howard-e
Update icon packs
7afe41b
@howard-e
webpack config changes
512ada5
@howard-e
Update bootstrap
420c822
@howard-e
Update eslint & jest
6ab5746
@howard-e
More dependency updates
d5c71f3
@howard-e
Update connect-pg-simple
c9ff257
@howard-e
Update dependencies and css
2e72491
@howard-e
Update css
8f87f12
@howard-e
Remove query-string dependency
e6f15f3
@howard-e
Update React
c786f57
@howard-e
jest.setup.js update
787a473
@howard-e
Fix attempt for @react-hook/resize-observer library import
9a916e6
@howard-e
Revert "Update React"
944130e 
This reverts commit d09df2f.
@howard-e
Update runtest.yml to use Node v18
fce646d
@evmiguel @howard-e
Updating form text (#485)
8aed201
@evmiguel @howard-e
Update dependencies test (#484)
7f2c2b2 
* Updating jest environment and babel configuration

* Trying nodegit 18 to fix builds

* New github config to fix builds

* Cacheing nodegit and fixing failing tests

* Upgrade lighthouse
@howard-e
Update React
f922a69
@howard-e
Revert "Update React"
56c2208 
This reverts commit d09df2f.
@alflennik @howard-e
Remove nodegit dependency
e436a2d
@alflennik @howard-e
Address PR feedback
b7f2012
@howard-e
Fix files affected by revert on source branch
0ccd643
@howard-e
Update React
f9bac4a
@howard-e
Revert "Update React"
944c873 
This reverts commit d09df2f.
@alflennik @howard-e
Fix fake data seeder
5e45a58
@howard-e
Fix files affected by revert on source branch
d7b9fff
@howard-e
Update React
059980a
@howard-e
Revert "Update React"
d791f17 
This reverts commit d09df2f.
@alflennik @howard-e
Remove sass dependency
e88c2b3
@howard-e
Fix files affected by revert on source branch
ab00ba6
Paul-Clue and others added 13 commits February 22, 2023 12:11
@Paul-Clue
Update gitUpdatedDateToString function arguments
1f989ba
@aleenaloves @howard-e @evmiguel
Updating react deps (#502)
63df985 
* Update React

* Revert "Update React"

This reverts commit d09df2f.

* Updating jest environment and babel configuration

* New github config to fix builds

* Cacheing nodegit and fixing failing tests

* update react in package.json

* Updating React-Testing-Library and removing acts (default now)

* adding text encoder, which is not added to jsdom

* fixing error

* updating react testing library dom

* fixing error

* updating react testing library dom

* Update yarn.lock

* Update React

* Revert "Update React"

This reverts commit d09df2f.

* Updating jest environment and babel configuration

* update react in package.json

* adding text encoder, which is not added to jsdom

* in prog

* fixing tests

* fixes

* pushing in changesss

* pages working

* cleaning up confirmAuth + candidateTests + routes index.js

* descendent routing in progress

* fixed candidate tests + test reports. TODO: test queue

* fixing typo: propotypes --> proptypes

* undoing irrelevant commits

* undoing uneccesary whitespaces

* removing unnecessary imports

* in prog

* fixing tests

* pushing in changesss

* pages working

* cleaning up confirmAuth + candidateTests + routes index.js

* descendent routing in progress

* undoing irrelevant commits

* undoing uneccesary whitespaces

* removing unnecessary imports

* Update yarn.lock

* report fixings

* fixing jest test expected

* removing unused import

* updated runtest.yml

* removing resize observer

* confirmed test expected is different per machine, reverting

* fixing resize-observer

* check for null | undefined testplanreports

* summarizetestplanversion reverts

* Re-enabling test on App.test.jsx

* updated testing library

* adding yarn lock

* yarn prettier

* Removing comment

---------

Co-authored-by: Howard Edwards <[email protected]>
Co-authored-by: Erika Miguel <[email protected]>
@evmiguel
Update rest of dependencies 2 (#503)
324b2b1 
* Upgrade prettier

* update babel

* Updating babel and prettier correctly

* Upgrade ua-parser-js and lighthouse cli

* Moving babel deps to dev dependencies

* updating prettier config

* prettier changes
@Paul-Clue
Merge branch 'update-dependencies' into update-sequelize
e35f1f4
@Paul-Clue
Merge pull request #501 from w3c/update-sequelize
7bdc230 
Update Sequelize ORM from v5 to v6
@Paul-Clue
Update sequelize-cli version (#508)
eec1b68 
* Update sequelize-cli version
* Update dependencies
@aleenaloves
Updating More Dependencies (#506)
94e313a 
* untested changes

* fixed storybook

* alphabetical

* changing to dev deps
@aleenaloves
disabled incomplete tests
85b7486
@aleenaloves
draft2
0153159
@aleenaloves
missing return added
08d4f66
@aleenaloves
complete
61dd8dc
@aleenaloves
in progress
774ddb1
@aleenaloves
cleaned up logic
4813296
@aleenaloves aleenaloves marked this pull request as draft March 2, 2023 18:31
@aleenaloves
Copy link
Contributor Author

pending test fixes.

@aleenaloves aleenaloves marked this pull request as ready for review March 2, 2023 18:44
@aleenaloves
Copy link
Contributor Author

tests fixed.

@evmiguel
Copy link
Contributor

evmiguel commented Mar 6, 2023

Are we ok with the copy: Test plans with incomplete tests cannot be finished. These tests should have their candidate status removed.? @jugglinmike @howard-e

Base automatically changed from update-dependencies to main March 8, 2023 16:53
@aleenaloves
Copy link
Contributor Author

pending copy notes from isaac

@aleenaloves aleenaloves marked this pull request as draft March 8, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

@evmiguel evmiguel Awaiting requested review from evmiguel

@howard-e howard-e Awaiting requested review from howard-e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aleenaloves @evmiguel @howard-e @alflennik @Paul-Clue