Report build failures during test import #496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the test-importing script would ignore errors in
the ARIA-AT project's build process. The script's subsequent behavior
was dependent on the particular failure, and if the problem was reported
at all, it would be in terms that were only indirectly related to the
root cause. For instance:
Error found: Error: ENOENT: no such file or directory, scandir '/home/mike/aria-at-app/server/scripts/import-tests/tmp/build/tests' [104/1957]
at Object.readdirSync (fs.js:1021:3)
at importTestPlanVersions (/home/mike/aria-at-app/server/scripts/import-tests/index.js:73:33)
error Command failed with exit code 1.
Immediately exit the test-importing script if the ARIA-AT project's
build process fails for any reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the test-importing script would ignore errors in the ARIA-AT project's build process. The script's subsequent behavior was dependent on the particular failure, and if the problem was reported at all, it would be in terms that were only indirectly related to the root cause. For instance:
Immediately exit the test-importing script if the ARIA-AT project's build process fails for any reason.
I ran into this because the ARIA-AT build process is failing on my system, but as noted in the commit message, any kind of failure will produce undefined results.