Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewriting abstract #1494

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Rewriting abstract #1494

merged 3 commits into from
Jan 9, 2020

Conversation

jakearchibald
Copy link
Contributor

@jakearchibald jakearchibald commented Jan 3, 2020

Fixes #1493


Preview | Diff

@jakearchibald jakearchibald requested a review from annevk January 3, 2020 10:33
docs/index.bs Outdated Show resolved Hide resolved
@jakearchibald
Copy link
Contributor Author

@jungkees @slightlyoff @mattto any thoughts about this before I merge?

@jungkees
Copy link
Collaborator

jungkees commented Jan 3, 2020

It seems to me that the first paragraph of the change seems a bit too specific in using terms. I think abstract should just explain what it is simply. In that regard, the original text reads easier.

To @annevk's point, I'll leave a comment in the issue.

@mfalken
Copy link
Member

mfalken commented Jan 6, 2020

I'm OK with this PR. Happy to take another look if you incorporate @jungkees's suggestions too.

@jakearchibald
Copy link
Contributor Author

@jungkees

It seems to me that the first paragraph of the change seems a bit too specific in using terms.

Hmm, I was trying to describe what the service worker is before things like the fetch event are added on top, and why it's used for particular event rather than just firing events in . a document.

Eg, I could remove some of the terms & make it:

The core of this specification is a worker that wakes to receive events. This provides an event destination that can be used when other destinations would be inappropriate, or no other destination exists.

Is that better?

Copy link
Collaborator

@jungkees jungkees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got your point. It looks good to me. Thanks for addressing my comment.

@jakearchibald jakearchibald merged commit 910cdd8 into master Jan 9, 2020
@jakearchibald jakearchibald deleted the abstract-adjust branch January 9, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate Abstract
4 participants