Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific Processing headings + minor editorial #1071

Merged
merged 1 commit into from
Feb 14, 2017

Conversation

sideshowbarker
Copy link
Contributor

This splits the “Link type "serviceworker"” ≫ “Processing” section into
two sections with separate headings:

  • Processing the Link header
  • Processing the link element

It also includes a minor editorial change to add the word “or” in a
place where lack of it makes the text ambiguous; this sentence:

When a serviceworker link’s link element is inserted into a document,
a serviceworker link is created on a link element that is already in a
document tree, or the href or scope attributes of the link element of a
serviceworker link is changed, the user agent should run these steps

...could be read as saying:

When a serviceworker link’s link element is inserted into a document,
then a serviceworker link is created on a link element...

When what it actually seems to mean is:

When a serviceworker link’s link element is inserted into a document,
or a serviceworker link is created on a link element...

That “or” is somewhat implied from the rest of the sentence, but this
this change just inserts an explicit “or” to make it more clear.

This splits the “Link type "serviceworker"” ≫ “Processing” section into
two sections with separate headings:

* Processing the Link header
* Processing the link element

It also includes a minor editorial change to add the word “or” in a
place where lack of it makes the text ambiguous; this sentence:

> When a serviceworker link’s link element is inserted into a document,
> a serviceworker link is created on a link element that is already in a
> document tree, or the href or scope attributes of the link element of a
> serviceworker link is changed, the user agent should run these steps

...could be read as saying:

> When a serviceworker link’s link element is inserted into a document,
> **then** a serviceworker link is created on a link element...

When what it actually seems to mean is:

> When a serviceworker link’s link element is inserted into a document,
> **or** a serviceworker link is created on a link element...

That “or” is somewhat implied from the rest of the sentence, but this
this change just inserts an explicit “or” to make it more clear.
@sideshowbarker
Copy link
Contributor Author

Marked as non-substantive for IPR from ash-nazg.

@jungkees
Copy link
Collaborator

LGTM.

a minor editorial change to add the word “or”

I think the original sentence was still okay to understand within the context but agree to this change with no strong opinion. /cc @mkruisselbrink

@jungkees jungkees merged commit e61d12e into master Feb 14, 2017
@jungkees jungkees deleted the sideshowbarker/add-processing-subheadings branch February 14, 2017 02:30
@jungkees
Copy link
Collaborator

Thanks @sideshowbarker!

@mkruisselbrink
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants