-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop isReload #873
Comments
Issue for the target client id #874 |
It's possible that knowing the reload button was pressed (or pull-to-refresh) is interesting enough to keep this feature, as the client Ids won't express that. |
Is the refresh button observable in the FetchEvent.cache value? Doesn't it set it to something that requires revalidation? |
Chrome seems to request with (guess you mean |
Sorry, I meant Gecko bug to fix that FetchEvent.request.cache value: https://bugzilla.mozilla.org/show_bug.cgi?id=1263469 |
Yeah, the cache mode is what is actually affected here. Nice catch. |
F2F: #875 - we can drop |
Spec is blocked on implementation. |
Pre F2F notes: Probably nothing to discuss here. |
Resolution:
|
I'd like to check if we're ready to drop this API. It seems Chromium bug for this (https://bugs.chromium.org/p/chromium/issues/detail?id=453190) is still in progress but its blocking issue (whatwg/fetch#39) had been closed. |
Our bug to drop this is https://bugs.chromium.org/p/chromium/issues/detail?id=652994. We're mostly blocked on implementing Request.cache (https://bugs.chromium.org/p/chromium/issues/detail?id=453190) and gathering usage data for FetchEvent.isReload (https://bugs.chromium.org/p/chromium/issues/detail?id=376039). I think it's ok for the spec to drop this and Chrome will eventually catch up. |
Let's move this question to #875. |
This is effective in Firefox 74. Source: * https://bugzilla.mozilla.org/show_bug.cgi?id=1264175 * w3c/ServiceWorker#873
This is effective in Firefox 74. Source: * https://bugzilla.mozilla.org/show_bug.cgi?id=1264175 * w3c/ServiceWorker#873
I think we should go lower level here.
If we supported #817 (comment) I'd be able to tell that a client of url was instigating a navigation request to the same url.
This may be a reload, or may be opening a new window, so additional information like "target" would be needed.
The text was updated successfully, but these errors were encountered: