Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRegistrations manipulates ES arrays in parallel steps #1241

Closed
bzbarsky opened this issue Dec 4, 2017 · 1 comment
Closed

getRegistrations manipulates ES arrays in parallel steps #1241

bzbarsky opened this issue Dec 4, 2017 · 1 comment
Assignees

Comments

@bzbarsky
Copy link

bzbarsky commented Dec 4, 2017

https://w3c.github.io/ServiceWorker/#navigator-service-worker-getRegistrations is manipulating "arrays" in parallel steps. The only "arrays" around in the web platform are ES Arrays, which is presumably what it's working with, since it then proceeds to resolve promises with some of these "arrays". It's not OK to touch ES arrays in parallel. Further, operations like adding to the array need to be carefully specified in terms of how it's actually done (defineProperty call? A property set? Something else?).

If these are meant to be infra Lists per https://infra.spec.whatwg.org/#lists that should be made explicit. Then the promise resolution bits need to be made a bit more explicit, possibly (e.g. how an Array is produced from the List).

@jakearchibald
Copy link
Contributor

jakearchibald commented Dec 7, 2017

PR #1243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants