Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Replace many instances of 'running' in favor of verbing nouns #359

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Jun 4, 2021

Editorial

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.

Preview | Diff

@inexorabletash
Copy link
Member Author

No good deed goes unpunished... can you take a look, @jakearchibald ?

Copy link
Contributor

@jakearchibald jakearchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Huh, I thought you'd have to change the definitions too, but… is bikeshed doing this automatically? I know it did pluralisation, but not this.

Edit oh hah you mentioned this in the other issue. TIL.

@inexorabletash
Copy link
Member Author

inexorabletash commented Jun 7, 2021

Yeah, Bikeshed magic. I noticed it only handles the first word being verbed, though, so more complex naming like "asynchronously execute a request" → "asynchronously executing a request" is not handled. Although I didn't touch that one since it's more subtle anyway.

@inexorabletash inexorabletash merged commit 22382f6 into main Jun 7, 2021
@inexorabletash inexorabletash deleted the running branch June 7, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants