-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sketch out spec text for transaction durability option #301
Conversation
I don't think we discussed whether we'd want options to be an alternative to mode. Worth figuring this out before we commit to the API shape described here? |
Excellent phrasing on the spec text. I don't think I personally have an opinion on the signature other than the overload stuff at https://heycam.github.io/webidl/#idl-overloading is complicated and the presence of optional arguments complicates things. (Specifically, in our attempt to eliminate Firefox's overload of |
As a third argument, it's a graceful fallback for older browsers - silently ignored. Which is great IMHO since it's just a hint. And it avoids an overload, which we're generally allergic to. Open to counter-arguments, though. A few things the patch needs:
|
52a4553
to
721f5a7
Compare
721f5a7
to
82ee311
Compare
82ee311
to
4d4ae3b
Compare
4d4ae3b
to
27681a2
Compare
Do we want to throw if a non-default option is set for readonly transactions? -- I agree with you. It makes more sense to me that all transactions have a durability property that behaves in the same way. Since it's intended to be a hint, the hint will be ignored in read-only transactions. |
Any objections to going forward with merging this? |
I tried to be cool in December and use a thumbs-up emoji, but I don't think that generated a notification, so to clarify, I'm good with merging this. |
Hah! Thanks for remembering. |
Closes #50
The following tasks have been completed:
Implementation commitment:
Preview | Diff